From: Thomas Gleixner <tglx@linutronix.de>
To: Eric Dumazet <edumazet@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-tip-commits@vger.kernel.org,
syzbot <syzkaller@googlegroups.com>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>
Subject: Re: [tip: timers/core] hrtimer: Annotate lockless access to timer->state
Date: Wed, 6 Nov 2019 23:16:51 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911062316310.1869@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CANn89iKBaEdCzgF-MT1wrxBZtBD2Ktr9qeThTG_XKOy742XcmQ@mail.gmail.com>
On Wed, 6 Nov 2019, Eric Dumazet wrote:
> > -static inline int hrtimer_is_queued(struct hrtimer *timer)
> > +static inline bool hrtimer_is_queued(struct hrtimer *timer)
> > {
> > - return timer->state & HRTIMER_STATE_ENQUEUED;
> > + /* The READ_ONCE pairs with the update functions of timer->state */
> > + return !!READ_ONCE(timer->state) & HRTIMER_STATE_ENQUEUED;
>
> You probably meant :
>
> return !!(READ_ONCE(timer->state) & HRTIMER_STATE_ENQUEUED);
>
> Sorry for not spotting this earlier.
Yes, I'm a moron....
next prev parent reply other threads:[~2019-11-06 22:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 17:48 [PATCH] " Eric Dumazet
2019-11-06 18:09 ` Thomas Gleixner
2019-11-06 18:19 ` Eric Dumazet
2019-11-06 19:15 ` Thomas Gleixner
2019-11-06 20:00 ` Eric Dumazet
2019-11-06 21:06 ` [tip: timers/core] " tip-bot2 for Eric Dumazet
2019-11-06 22:02 ` Eric Dumazet
2019-11-06 22:16 ` Thomas Gleixner [this message]
2019-11-06 22:24 ` tip-bot2 for Eric Dumazet
2019-11-06 22:53 ` Eric Dumazet
2019-11-06 22:59 ` Eric Dumazet
2019-11-07 8:52 ` Paul E. McKenney
2019-11-07 15:48 ` Eric Dumazet
2019-11-07 16:11 ` Paul E. McKenney
2019-11-07 16:35 ` Eric Dumazet
2019-11-07 16:39 ` Eric Dumazet
2019-11-07 16:54 ` Paul E. McKenney
2019-11-07 16:59 ` Eric Dumazet
2019-11-07 17:07 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911062316310.1869@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®