From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 298EAC432C0 for ; Wed, 27 Nov 2019 15:55:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0944820684 for ; Wed, 27 Nov 2019 15:55:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727017AbfK0PzU (ORCPT ); Wed, 27 Nov 2019 10:55:20 -0500 Received: from gentwo.org ([3.19.106.255]:39434 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfK0PzU (ORCPT ); Wed, 27 Nov 2019 10:55:20 -0500 Received: by gentwo.org (Postfix, from userid 1002) id 3C4263EF16; Wed, 27 Nov 2019 15:55:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 3A32F3EC1C; Wed, 27 Nov 2019 15:55:19 +0000 (UTC) Date: Wed, 27 Nov 2019 15:55:19 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Luc Van Oostenryck cc: Dennis Zhou , Ben Dooks , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Nicholas Piggin , Arnd Bergmann Subject: Re: [PATCH] fix __percpu annotation in asm-generic In-Reply-To: <20191126200619.63348-1-luc.vanoostenryck@gmail.com> Message-ID: References: <20191126200619.63348-1-luc.vanoostenryck@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Nov 2019, Luc Van Oostenryck wrote: > So, fix the declaration of the 'pcp' variable to its correct type: > the plain (non-percpu) pointer corresponding to its address. > Same for raw_cpu_generic_xchg(), raw_cpu_generic_cmpxchg() & > raw_cpu_generic_cmpxchg_double(). Acked-by: Christoph Lameter Maybe a better fix is to come up with a typeof_strip_percu() or so macro for all the places where this needs to be done?