From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D20C7114E for ; Sun, 16 Feb 2020 01:21:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 661D42084E for ; Sun, 16 Feb 2020 01:21:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VPkrR4aA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727780AbgBPBVu (ORCPT ); Sat, 15 Feb 2020 20:21:50 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39900 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726389AbgBPBVu (ORCPT ); Sat, 15 Feb 2020 20:21:50 -0500 Received: by mail-pf1-f195.google.com with SMTP id 84so6972152pfy.6 for ; Sat, 15 Feb 2020 17:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ZdGxk1PBOKOGawhQcLNZeyTj/xo8WHGgfqy1y6yzHoY=; b=VPkrR4aAn3aJbX9HSDDpW0USRaDzSdhdN+om9MlIpf6mSMxKE35qtR6HicoM83bMWF 89aYUdl45Sd9QDTwpOs1ibLUQ0VqCTwOaZnAyXwClrb0QZ3LqHT2DQKNTGE5B0JeCzlw xQ06CSwG/XgtL+KBooQLph9KI5KyG3IdZ6tVc6PU/RveF/3awRvdk5p/6qyOHDdjX3GT gv4LGYBtF7uptKcEPBwSoE47pJuBGW2azc0j4bCn+Z332aoPAvIzfVn+DrIRIMqnLzFf YDR5Zfn0kFCTx9DMfbNdSbbwquq8tvMk73seGGqxATgAE501P6q3vyVnpSJA1VctTYP0 heFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ZdGxk1PBOKOGawhQcLNZeyTj/xo8WHGgfqy1y6yzHoY=; b=Bl1TuFg0l0RB2rbEQAV4LDPOdHqrUMtVIJOoYdoEX08D7yDidb4g3pW4oFiI78wHdB Vsn7doHgZpSESbFGI1PUmd4N2hOME/ivCeZCQZv0AVm852qoVFiynKX/z0PBMF82kJIe pzJBKT6T/IsqVRWqhHtJ60kb9DebeX2aetMdyg4q6SO3FRRZ1rhOLwAddkc5RFq1Z891 HDNy6vJAlrLBfwTXZfXQHONPkaV4V9iKhiG9BSS2rIlXWAbkkVaPROw9qthNWaGp5Eha 6aKfC3psUHX22olOxaTvtwMAJ0FCvDoQ58MH7zM+CzmcejFuIJ9WIaWa/Twddtj9ZIMc d+lw== X-Gm-Message-State: APjAAAUWIRI3BTGRVyivOCAp+H02sewUJuT8ut7rSp28m/UpgE/MU1S+ b1t8E9vavTqv09HFPcuhHYPSo4N48ZM= X-Google-Smtp-Source: APXvYqwoLzYHO2Gi/QE5EcOl6jXQX5heYxareWbnikLCtYc4q3Ka3yDvQBaUmfxTlHxMIiSuHEeoRw== X-Received: by 2002:a63:e257:: with SMTP id y23mr11028582pgj.104.1581816109493; Sat, 15 Feb 2020 17:21:49 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id d1sm11803545pgj.79.2020.02.15.17.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2020 17:21:48 -0800 (PST) Date: Sat, 15 Feb 2020 17:21:48 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Mike Kravetz cc: Mina Almasry , shuah@kernel.org, shakeelb@google.com, gthelen@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v12 2/9] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations In-Reply-To: <791880db-bdb0-8d34-ea9a-be6e4996fc0d@oracle.com> Message-ID: References: <20200211213128.73302-1-almasrymina@google.com> <20200211213128.73302-2-almasrymina@google.com> <791880db-bdb0-8d34-ea9a-be6e4996fc0d@oracle.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Feb 2020, Mike Kravetz wrote: > On 2/11/20 1:31 PM, Mina Almasry wrote: > > Augments hugetlb_cgroup_charge_cgroup to be able to charge hugetlb > > usage or hugetlb reservation counter. > > > > Adds a new interface to uncharge a hugetlb_cgroup counter via > > hugetlb_cgroup_uncharge_counter. > > > > Integrates the counter with hugetlb_cgroup, via hugetlb_cgroup_init, > > hugetlb_cgroup_have_usage, and hugetlb_cgroup_css_offline. > > > > Signed-off-by: Mina Almasry > > > > Thanks for the suggested changes. It will make the code easier to > read and understand. > > Acked-by: Mike Kravetz Agreed, thanks Mina! Acked-by: David Rientjes