From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B51DAC43331 for ; Fri, 27 Mar 2020 08:11:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 949B520716 for ; Fri, 27 Mar 2020 08:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726418AbgC0ILq (ORCPT ); Fri, 27 Mar 2020 04:11:46 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:63389 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgC0ILq (ORCPT ); Fri, 27 Mar 2020 04:11:46 -0400 X-IronPort-AV: E=Sophos;i="5.72,311,1580770800"; d="scan'208";a="343986645" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 09:11:44 +0100 Date: Fri, 27 Mar 2020 09:11:44 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Daniel Vetter cc: kbuild-all@lists.01.org, Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm: fix ifnullfree.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NULL check before kfree is not needed. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: c6603c740e0e ("drm: add managed resources tied to drm_device") Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 9e1ed9fb1eb0a4bc43a26365c592d3095286038b commit: c6603c740e0e3492c9c95fdab833375bf7117b6b [1587/1636] drm: add managed resources tied to drm_device :::::: branch date: 8 hours ago :::::: commit date: 9 hours ago Up to you, if you tihnk it is useful... drm_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -837,8 +837,9 @@ static void drm_dev_release(struct kref if (!dev->driver->release && !dev->managed.final_kfree) { WARN_ON(!list_empty(&dev->managed.resources)); kfree(dev); - } else if (dev->managed.final_kfree) + } else { kfree(dev->managed.final_kfree); + } } /**