From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C4EDC2BA12 for ; Thu, 2 Apr 2020 07:11:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CDAA20784 for ; Thu, 2 Apr 2020 07:11:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387665AbgDBHLd (ORCPT ); Thu, 2 Apr 2020 03:11:33 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:20827 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726743AbgDBHLc (ORCPT ); Thu, 2 Apr 2020 03:11:32 -0400 X-IronPort-AV: E=Sophos;i="5.72,334,1580770800"; d="scan'208";a="443452906" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2020 09:11:30 +0200 Date: Thu, 2 Apr 2020 09:11:30 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: "John B. Wyatt IV" cc: outreachy-kernel@googlegroups.com, Laura Abbott , Sumit Semwal , Greg Kroah-Hartman , =?ISO-8859-15?Q?Arve_Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: android: ion: Fix parenthesis alignment In-Reply-To: <20200402012515.429329-1-jbwyatt4@gmail.com> Message-ID: References: <20200402012515.429329-1-jbwyatt4@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Apr 2020, John B. Wyatt IV wrote: > Fix 2 parenthesis alignment issues. Please try to find a way to describe what you have done that doesn't involve the word "Fix". What have you done and why? julia > > Reported by checkpatch. > > Signed-off-by: John B. Wyatt IV > --- > drivers/staging/android/ion/ion_page_pool.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c > index f85ec5b16b65..0198b886d906 100644 > --- a/drivers/staging/android/ion/ion_page_pool.c > +++ b/drivers/staging/android/ion/ion_page_pool.c > @@ -37,7 +37,7 @@ static void ion_page_pool_add(struct ion_page_pool *pool, struct page *page) > } > > mod_node_page_state(page_pgdat(page), NR_KERNEL_MISC_RECLAIMABLE, > - 1 << pool->order); > + 1 << pool->order); > mutex_unlock(&pool->mutex); > } > > @@ -57,7 +57,7 @@ static struct page *ion_page_pool_remove(struct ion_page_pool *pool, bool high) > > list_del(&page->lru); > mod_node_page_state(page_pgdat(page), NR_KERNEL_MISC_RECLAIMABLE, > - -(1 << pool->order)); > + -(1 << pool->order)); > return page; > } > > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200402012515.429329-1-jbwyatt4%40gmail.com. >