From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FDCFC83008 for ; Tue, 28 Apr 2020 14:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D332206C0 for ; Tue, 28 Apr 2020 14:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727983AbgD1OGa (ORCPT ); Tue, 28 Apr 2020 10:06:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726942AbgD1OGa (ORCPT ); Tue, 28 Apr 2020 10:06:30 -0400 Received: from albert.telenet-ops.be (albert.telenet-ops.be [IPv6:2a02:1800:110:4::f00:1a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD4CBC03C1A9 for ; Tue, 28 Apr 2020 07:06:29 -0700 (PDT) Received: from ramsan ([IPv6:2a02:1810:ac12:ed60:d03f:8af3:4e83:6587]) by albert.telenet-ops.be with bizsmtp id YE6S2200U27aUyk06E6S0e; Tue, 28 Apr 2020 16:06:26 +0200 Received: from geert (helo=localhost) by ramsan with local-esmtp (Exim 4.90_1) (envelope-from ) id 1jTQsU-0003Ly-B4; Tue, 28 Apr 2020 16:06:26 +0200 Date: Tue, 28 Apr 2020 16:06:26 +0200 (CEST) From: Geert Uytterhoeven To: Mauro Carvalho Chehab cc: Linux Media Mailing List , Hans Verkuil , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] media: place CEC menu before MEDIA_SUPPORT In-Reply-To: <32565659d6778e92bd9ac7d17622149bd95973c5.1586944045.git.mchehab+huawei@kernel.org> Message-ID: References: <32565659d6778e92bd9ac7d17622149bd95973c5.1586944045.git.mchehab+huawei@kernel.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro, On Wed, 15 Apr 2020, Mauro Carvalho Chehab wrote: > The only item that opens at the CEC Kconfig menu is related > to Remote Controller. Also, its support should not depend on > media support, so it makes sense to keep both RC and CEC together. > > After this change, the main media menus that are visible > under "Device Drivers" menu are: > > <*> Remote Controller support ---> > [ ] HDMI CEC RC integration (NEW) > < > HDMI CEC drivers > Multimedia support ---> > > Signed-off-by: Mauro Carvalho Chehab Thanks for your patch, which is now commit 46d2a3b964ddbe63 ("media: place CEC menu before MEDIA_SUPPORT") in media/master. > --- a/drivers/media/cec/Kconfig > +++ b/drivers/media/cec/Kconfig > @@ -11,3 +20,14 @@ config CEC_PIN_ERROR_INJ > depends on CEC_PIN && DEBUG_FS > help > This option enables CEC error injection using debugfs. > + > +config MEDIA_CEC_SUPPORT > + bool > + prompt "HDMI CEC drivers" This is now visible in a media-less and head-less kernel... > + default y if !MEDIA_SUPPORT_FILTER ... and in that case even defaults to y: $ grep MEDIA .config CONFIG_MEDIA_CEC_SUPPORT=y # CONFIG_MEDIA_SUPPORT is not set Is that intentional? > + help > + Enable support for HDMI CEC (Consumer Electronics Control), > + which is an optional HDMI feature. > + > + Say Y when you have an HDMI receiver, transmitter or a USB CEC > + adapter that supports HDMI CEC. > -- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds