From: Julia Lawall <julia.lawall@inria.fr>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jason Yan <yanaijie@huawei.com>,
mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk,
Julia.Lawall@lip6.fr
Subject: Re: [PATCH] sched/fair: Return true,false in voluntary_active_balance()
Date: Fri, 8 May 2020 11:24:30 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2005081120510.5307@hadrien> (raw)
In-Reply-To: <20200508081629.GN5298@hirez.programming.kicks-ass.net>
On Fri, 8 May 2020, Peter Zijlstra wrote:
> On Thu, May 07, 2020 at 07:06:25PM +0800, Jason Yan wrote:
> > Fix the following coccicheck warning:
> >
> > kernel/sched/fair.c:9375:9-10: WARNING: return of 0/1 in function
> > 'voluntary_active_balance' with return type bool
>
> That's not a warning, that's a broken cocinelle script, which if these
> stupid patches don't stop, I'm going to delete myself!
Peter,
If you don't like the script, please feel free to delete it.
Currently, no one is really maintaining (ie pushing patches to Linus) the
scripts directory. Masahiro Yamada was doing it but has expressed several
times that he doesn't want to. I got a kernel.org account, but clearly
haven't had time to figure out how to use it appropriately. But simply
deleting a file is simple and risk free, so if you want to make the
change please go ahead.
julia
prev parent reply other threads:[~2020-05-08 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 11:06 Jason Yan
2020-05-07 11:17 ` Valentin Schneider
2020-05-07 17:28 ` Steven Rostedt
2020-05-07 17:30 ` Steven Rostedt
2020-05-07 17:52 ` Valentin Schneider
2020-05-07 17:55 ` Joe Perches
2020-05-07 18:45 ` Steven Rostedt
2020-05-07 19:06 ` Joe Perches
2020-05-07 19:45 ` Steven Rostedt
2020-05-07 20:18 ` Joe Perches
2020-05-08 8:16 ` Peter Zijlstra
2020-05-08 9:06 ` Rasmus Villemoes
2020-05-08 9:24 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2005081120510.5307@hadrien \
--to=julia.lawall@inria.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®