From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A27D4C433DF for ; Fri, 24 Jul 2020 10:05:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8578D2065C for ; Fri, 24 Jul 2020 10:05:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727786AbgGXKFe (ORCPT ); Fri, 24 Jul 2020 06:05:34 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:54935 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbgGXKFd (ORCPT ); Fri, 24 Jul 2020 06:05:33 -0400 X-IronPort-AV: E=Sophos;i="5.75,390,1589234400"; d="scan'208";a="355208215" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2020 12:05:31 +0200 Date: Fri, 24 Jul 2020 12:05:31 +0200 (CEST) From: Julia Lawall X-X-Sender: julia@hadrien To: John Ogness cc: Sebastian Andrzej Siewior , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org, kbuild-all@lists.01.org Subject: [PATCH] printk: fix ifnullfree.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make the code a little simpler by dropping some unneeded tests. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: c406fbce2054 ("printk: implement syslog") CC: John Ogness Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.4.y-rt head: 5fbf1e70f11dba64cc05c9d85120a3aa7c67a4a2 commit: c406fbce2054efbf812b3d811ed23a872f719db9 [43/325] printk: implement syslog :::::: branch date: 4 months ago :::::: commit date: 7 months ago printk.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -1539,10 +1539,8 @@ static int syslog_print_all(char __user if (clear && !seq) syslog_clear(); - if (text) - kfree(text); - if (msgbuf) - kfree(msgbuf); + kfree(text); + kfree(msgbuf); return len; } @@ -1695,10 +1693,8 @@ int do_syslog(int type, char __user *buf break; } out: - if (msgbuf) - kfree(msgbuf); - if (text) - kfree(text); + kfree(msgbuf); + kfree(text); return error; }