From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DABEC31E57 for ; Mon, 17 Jun 2019 09:58:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32A6720848 for ; Mon, 17 Jun 2019 09:58:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="GztjFeCg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727907AbfFQJ6Y (ORCPT ); Mon, 17 Jun 2019 05:58:24 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:35852 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727518AbfFQJ6X (ORCPT ); Mon, 17 Jun 2019 05:58:23 -0400 Received: by mail-ed1-f66.google.com with SMTP id k21so15312856edq.3 for ; Mon, 17 Jun 2019 02:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=k/FkMrNeRTkozEqierq2rmbV5zRaMHg6J2eVIWl4duU=; b=GztjFeCgsx2WVQQlaCXYbhcPsiu/7YqqR997H6U3zan9rYs0xa6xFeiRivc/RtwM4x b/Q9XQ210Gv+8E+J7NDLQUrKd2naU4exI1G+xlsKnjxh/RGc/6gcZqi2NpV2DfMZRC5K uidbnB9l/Kn69qIo4+cWA4rb4+B2Fbf4QJ/WAvydPHIP2SHKcIj6K6yDJx+lbjldoNwQ UP6mmVLBfZ9zo0ukP6Krhe016u7ATMe7UCtiXsIHvD6jCTsMINZu9tNSxpgXv2A5W3EG yp6OIeyJeWq7Gzf4F/jGva/OHSnuOxtAeQ0eLKUmMQ9+PLwB9QJyd3EX1UeD+D7wl7ni xSCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=k/FkMrNeRTkozEqierq2rmbV5zRaMHg6J2eVIWl4duU=; b=FcX5kXN/D4qeLtUUCLzS83YozhpwEUyOrLuJeJbcssMlBhTagitAwCngCMEA/uI44/ c98Hh3SVpUHG/CXih+PFJ7K59BZv1rOBFH378QE1UKnavdqWG+Q7m1oCpQRMIbZ1XCSb kZY1mryu1OYr75LIoBebU6J+h33icLWJ2Jjgyo57OiHYANG4FUfeaoc4OGkuTUORGbNu SnRQPWmjmPEuJsf5fK2M1sbdMktkiUP9X7Rk/+wOMaBWVwcP9IZpfAO7qd5XNmBKD4NN ObsaRaMAOCDIwMnHy13Wlx9C2gu/WRdwYGn1R8bdxe0Jqxd4KU9XBaIphKY1cnCx90Eu s0SQ== X-Gm-Message-State: APjAAAW/5XsWQrv+Ou+ccd4Rl/4g+PKp2xUwcCiSh+b+OBC3MIomUlTW JRHLYF318gMH06ST9+tzrnRP1g== X-Google-Smtp-Source: APXvYqzzFOn2TYEUiWfO5QA45ng6P677kxEghJAuKXYs/UNNAuPRaE//NwSmVe/Dj1EArVjJXXbs+A== X-Received: by 2002:a50:ad45:: with SMTP id z5mr95083437edc.21.1560765501430; Mon, 17 Jun 2019 02:58:21 -0700 (PDT) Received: from localhost ([81.92.102.43]) by smtp.gmail.com with ESMTPSA id d5sm2095575ejk.71.2019.06.17.02.58.20 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 17 Jun 2019 02:58:20 -0700 (PDT) Date: Mon, 17 Jun 2019 02:58:20 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Yash Shah cc: Andreas Schwab , davem@davemloft.net, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, robh+dt@kernel.org, mark.rutland@arm.com, nicolas.ferre@microchip.com, palmer@sifive.com, aou@eecs.berkeley.edu, ynezz@true.cz, sachin.ghadi@sifive.com Subject: Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000 In-Reply-To: Message-ID: References: <1560745167-9866-1-git-send-email-yash.shah@sifive.com> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yash, On Mon, 17 Jun 2019, Andreas Schwab wrote: > On Jun 17 2019, Yash Shah wrote: > > > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb > > driver. This is needed because on FU540, the macb driver depends on > > SiFive GPIO driver. > > This of course requires that the GPIO driver is upstreamed first. What's the impact of enabling CONFIG_MACB_SIFIVE_FU540 when the GPIO driver isn't present? (After modifying the Kconfig "depends" line appropriately.) Looks to me that it shouldn't have an impact unless the DT string is present, and even then, the impact might simply be that the MACB driver may not work? - Paul