From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54418C3A5A6 for ; Thu, 29 Aug 2019 01:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2845E215EA for ; Thu, 29 Aug 2019 01:30:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="N0Tiu7A4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbfH2BaR (ORCPT ); Wed, 28 Aug 2019 21:30:17 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44431 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726369AbfH2BaQ (ORCPT ); Wed, 28 Aug 2019 21:30:16 -0400 Received: by mail-pg1-f193.google.com with SMTP id i18so654842pgl.11 for ; Wed, 28 Aug 2019 18:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=oNuMQ0k3tolgyGaRQrF7TXZFayppiTIHnhst6LSZzgM=; b=N0Tiu7A4E04tZ0bGKbShdzjcMamCLdZF8w9OOQK6PqJNfA15z95T1h2MEkAr1QGrkv MTmnaoNxMhluJ+2QIg5wgRlKZG4ebI1krbhI2gFwPGhzgjl3Mo9eYwmeXkS342XWdvW2 6o8joBVW/w2HTRLZcmWXJgsyKzxaDVdpZopFc+IAFxfJItzbjS6MQxV8iMzvMh+wCbxD Jlu+YvTpNL5xNRiykc69s779w7U0EiJlNB8fL9OGeoCN3UhQ1qRDkxoOPgj2e9fdO+nP rUwqW2dh56+pi8vTJEXJED0sq/nTmn2tjeRp9FDE/GII0XdAAqqoM5RIQmupCWDxlq+V rHBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=oNuMQ0k3tolgyGaRQrF7TXZFayppiTIHnhst6LSZzgM=; b=eE/jox2gdwYPuFNMSaMr41WfTM7iUHCbG1WhGMqD8FFU26q+m/XSt4vK7qeNgL3txk UymjKRfojiDMSaf6ap1qUCJQEMiYxWCqYTPynM5b0jJUaLziXaOaqwb8u0NQkiM9MjYk ZxFL0yELG8I9AJyfXvGv7zfU/XZJ+RzDgwfkjM2pyzhePiOperilf098ChA9XSTBsUQG HdtuWk7UYMVqfCCbV/642oZd6jlkUb53xoB4nL9GmX29J55KmhACquv2jJhy+Usrogi2 ffjrVit3obcuS0Kv083vBsTQCOBwWgxCoCGHcgChbCDzlv1DZw2cpV7nWBhToeTDuQEX ZM0g== X-Gm-Message-State: APjAAAXbkOBuWlRttU6baM7JIJjNEB50AEFUUZiHcDdzQQDXwxjzSbII RpxXo5cOf5DYewE0l7SvFVaknQ== X-Google-Smtp-Source: APXvYqzneWTer11an0OtynaQ0NdmFFtoQFTgNrY29fSA6ajAUSOjqiO56Ptl9fWn/+Jpt6o1LcWHIg== X-Received: by 2002:aa7:8602:: with SMTP id p2mr8123966pfn.138.1567042216270; Wed, 28 Aug 2019 18:30:16 -0700 (PDT) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id y13sm669451pfm.164.2019.08.28.18.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 18:30:15 -0700 (PDT) Date: Wed, 28 Aug 2019 18:30:14 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Kees Cook , Tycho Andersen cc: David Abdurachmanov , Palmer Dabbelt , Albert Ou , Oleg Nesterov , Andy Lutomirski , Will Drewry , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , David Abdurachmanov , Thomas Gleixner , Allison Randal , Alexios Zavras , Anup Patel , Vincent Chen , Alan Kao , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, me@carlosedp.com Subject: Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER In-Reply-To: <201908261043.08510F5E66@keescook> Message-ID: References: <20190822205533.4877-1-david.abdurachmanov@sifive.com> <20190826145756.GB4664@cisco> <201908261043.08510F5E66@keescook> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kees, On Mon, 26 Aug 2019, Kees Cook wrote: > On Mon, Aug 26, 2019 at 09:39:50AM -0700, David Abdurachmanov wrote: > > I don't have the a build with SECCOMP for the board right now, so it > > will have to wait. I just finished a new kernel (almost rc6) for Fedora, > > FWIW, I don't think this should block landing the code: all the tests > fail without seccomp support. ;) So this patch is an improvement! Am sympathetic to this -- we did it with the hugetlb patches for RISC-V -- but it would be good to understand a little bit more about why the test fails before we merge it. Once we merge the patch, it will probably reduce the motivation for others to either understand and fix the underlying problem with the RISC-V code -- or, if it truly is a flaky test, to drop (or fix) the test in the seccomp_bpf kselftests. Thanks for helping to take a closer look at this, - Paul