From: Paul Walmsley <paul.walmsley@sifive.com>
To: Anup Patel <anup@brainfault.org>
Cc: Alistair Francis <Alistair.Francis@wdc.com>,
Anup Patel <Anup.Patel@wdc.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rkir@google.com" <rkir@google.com>,
"hch@infradead.org" <hch@infradead.org>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"palmer@sifive.com" <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver
Date: Tue, 22 Oct 2019 23:00:44 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1910222250490.5600@viisi.sifive.com> (raw)
In-Reply-To: <CAAhSdy3KccuzC0pV6Jy_diLwkdgb=SdHBQnsSoGrgpu6g7TCQA@mail.gmail.com>
On Wed, 23 Oct 2019, Anup Patel wrote:
> On Wed, Oct 23, 2019 at 6:37 AM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> > Incidentally, just looking at drivers/platform/goldfish, that driver seems
> > to be some sort of Google-specific RPC driver. Are you all really sure
>
> Nopes, it's not RPC driver. In fact, all Goldfish virtual platform
> devices are MMIO devices.
Is drivers/platform/goldfish/goldfish_pipe.c required for the Goldfish RTC
driver or not?
If not, then the first patch that was sent isn't the right fix. It would
be better to remove the Kbuild dependency between the code in
drivers/platform/goldfish and the Goldfish RTC.
If it is required, then surely there must be a simpler RTC implementation
available.
> The problem is VirtIO spec does not define any RTC device so instead of
> inventing our own virtual RTC device we re-use RTC device defined in
> Goldfish virtual platform for QEMU virt machine. This way we can re-use
> the Linux Goldfish RTC driver.
With 160+ RTC drivers in the kernel tree already, we certainly agree that
it doesn't make sense to invent a new RTC.
- Paul
next prev parent reply other threads:[~2019-10-23 6:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 6:37 [PATCH v2 0/2] Enable Goldfish RTC for RISC-V Anup Patel
2019-09-25 6:37 ` [PATCH v2 1/2] platform: goldfish: Allow goldfish drivers for archs with IOMEM and DMA Anup Patel
2019-09-25 6:38 ` [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver Anup Patel
2019-10-12 17:38 ` Palmer Dabbelt
2019-10-14 9:20 ` Anup Patel
2019-10-22 19:23 ` Paul Walmsley
2019-10-22 22:53 ` Alistair Francis
2019-10-23 1:06 ` Paul Walmsley
2019-10-23 3:24 ` Anup Patel
2019-10-23 6:00 ` Paul Walmsley [this message]
2019-10-23 6:12 ` Anup Patel
2019-10-23 6:49 ` Paul Walmsley
2019-10-23 17:42 ` Alistair Francis
2019-10-23 18:20 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1910222250490.5600@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®