From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B51C433DF for ; Fri, 12 Jun 2020 10:30:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B8D620792 for ; Fri, 12 Jun 2020 10:30:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726275AbgFLKaT (ORCPT ); Fri, 12 Jun 2020 06:30:19 -0400 Received: from mga18.intel.com ([134.134.136.126]:17570 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgFLKaN (ORCPT ); Fri, 12 Jun 2020 06:30:13 -0400 IronPort-SDR: MLYq0/+hhbKCmc57Svh3BZyGYCNkqPrU3M/fewo21KCc12LjCojxbIaphjRp3OBGqELj9nqSX1 tQjDjkz/Xghw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2020 03:30:05 -0700 IronPort-SDR: FB7TDU6toUsBW8rgmmhkVAjuNlzXccIiopAQ9bo5sN9VfuAVt0LvcsBhAlbL8R29lkBq7UN9Vh fvLdMhYVQ04Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,502,1583222400"; d="scan'208";a="419425987" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by orsmga004.jf.intel.com with ESMTP; 12 Jun 2020 03:30:00 -0700 Date: Fri, 12 Jun 2020 13:29:52 +0300 (EEST) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Brent Lu cc: alsa-devel@alsa-project.org, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Zhu Yingjiang , Keyon Jie , Bard Liao , sound-open-firmware@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: SOF: Intel: hda: unsolicited RIRB response Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brent, On Fri, 12 Jun 2020, Brent Lu wrote: > Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading > WP") from legacy HDA driver to fix the get response timeout issue. > Current SOF driver does not suffer from this issue because sync write > is enabled in hda_init. The issue will come back if the sync write is > disabled for some reason. better to align the logic, so I'm ok to take this patch to SOF. Can you fix the summary though: - ASoC: SOF: Intel: hda: unsolicited RIRB response + ASoC: SOF: Intel: hda: Clear RIRB status before reading WP Br, Kai