From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C68C433E0 for ; Sat, 20 Jun 2020 13:46:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C32823A5F for ; Sat, 20 Jun 2020 13:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728189AbgFTNqg (ORCPT ); Sat, 20 Jun 2020 09:46:36 -0400 Received: from mailbackend.panix.com ([166.84.1.89]:58527 "EHLO mailbackend.panix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728051AbgFTNqe (ORCPT ); Sat, 20 Jun 2020 09:46:34 -0400 Received: from xps-7390 (cpe-23-242-39-94.socal.res.rr.com [23.242.39.94]) by mailbackend.panix.com (Postfix) with ESMTPSA id 49pxm66YxDz17f6; Sat, 20 Jun 2020 09:46:30 -0400 (EDT) Date: Sat, 20 Jun 2020 06:46:27 -0700 (PDT) From: "Kenneth R. Crudup" Reply-To: "Kenneth R. Crudup" To: Christoph Hellwig cc: Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: Commit 25f12ae45fc1 ("maccess: rename probe_kernel_address to get_kernel_nofault") causing several OOPSes In-Reply-To: <20200619074233.GA3723@lst.de> Message-ID: References: <20200619065007.GA3041@lst.de> <20200619074233.GA3723@lst.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Thing is, there's other examples of the previous version in the kernel tree- any > > chance there's a usage conflict (Thunderbolt has a ROM in it, maybe something in > > "probe_roms.c"? (Just guessing, no idea): On Fri, 19 Jun 2020, Christoph Hellwig wrote: > Maybe. But nothing looks strange there. Just to re-reconfirm, you had to > revert "maccess: rename probe_kernel_address to get_kernel_nofault", > "maccess: make get_kernel_nofault() check for minimal type compatibility" > wasn't enough? Yeah, the only commit I had to revert was this one. BUT: > Below is a patch to do a "partial revert" for probe_roms.c. I'd be > totally surprised if it changes anything from staring at it for while, > but anyway.. So, be totally surprised :) I've just booted with "maccess: rename probe_kernel_address to get_kernel_nofault" intact and your probe_roms.c patch with no issues. (Perhaps there's some sort of compiler optimization going on?) -Kenny -- Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Orange County CA