From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6FD6C433DF for ; Mon, 22 Jun 2020 08:59:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D81020720 for ; Mon, 22 Jun 2020 08:59:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbgFVI7O (ORCPT ); Mon, 22 Jun 2020 04:59:14 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:35842 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725802AbgFVI7M (ORCPT ); Mon, 22 Jun 2020 04:59:12 -0400 X-IronPort-AV: E=Sophos;i="5.75,266,1589234400"; d="scan'208";a="352318332" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jun 2020 10:59:08 +0200 Date: Mon, 22 Jun 2020 10:59:08 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Matthias Maennich cc: Shuah Khan , linux-kernel@vger.kernel.org, kernel-team@android.com, YueHaibing , jeyu@kernel.org, cocci@systeme.lip6.fr, stable@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci In-Reply-To: <20200622080345.GD260206@google.com> Message-ID: References: <20200604164145.173925-1-maennich@google.com> <20200622080345.GD260206@google.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jun 2020, Matthias Maennich wrote: > On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote: > > On 6/4/20 1:31 PM, Julia Lawall wrote: > > > > > > > > > On Thu, 4 Jun 2020, Matthias Maennich wrote: > > > > > > > When running `make coccicheck` in report mode using the > > > > add_namespace.cocci file, it will fail for files that contain > > > > MODULE_LICENSE. Those match the replacement precondition, but spatch > > > > errors out as virtual.ns is not set. > > > > > > > > In order to fix that, add the virtual rule nsdeps and only do search and > > > > replace if that rule has been explicitly requested. > > > > > > > > In order to make spatch happy in report mode, we also need a dummy rule, > > > > as otherwise it errors out with "No rules apply". Using a script:python > > > > rule appears unrelated and odd, but this is the shortest I could come up > > > > with. > > > > > > > > Adjust scripts/nsdeps accordingly to set the nsdeps rule when run trough > > > > `make nsdeps`. > > > > > > > > Suggested-by: Julia Lawall > > > > Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed") > > > > Cc: YueHaibing > > > > Cc: jeyu@kernel.org > > > > Cc: cocci@systeme.lip6.fr > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Matthias Maennich > > > > > > Acked-by: Julia Lawall > > > > > > Shuah reported the problem to me, so you could add > > > > > > Reported-by: Shuah Khan > > > > > > > Very cool. No errors with this patch. Thanks for fixing it > > quickly. > > I am happy I could fix that and thanks for confirming. I assume your > Tested-by could be added? Yes, that would be fine. julia > > Is somebody willing to take this patch through their tree? > > Cheers, > Matthias > > > > > thanks, > > -- Shuah > > > > > > >