From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8570DC433DF for ; Tue, 4 Aug 2020 20:38:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7463F20842 for ; Tue, 4 Aug 2020 20:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727887AbgHDUiM (ORCPT ); Tue, 4 Aug 2020 16:38:12 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:40524 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727035AbgHDUiL (ORCPT ); Tue, 4 Aug 2020 16:38:11 -0400 X-IronPort-AV: E=Sophos;i="5.75,435,1589234400"; d="scan'208";a="355951290" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2020 22:38:09 +0200 Date: Tue, 4 Aug 2020 22:38:08 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Sumera Priyadarsini cc: michal.lkml@markovi.net, Gilles.Muller@lip6.fr, gregkh@linuxfoundation.org, nicolas.palix@imag.fr, linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr Subject: Re: [Cocci] [PATCH] scripts: coccicheck: Add chain mode to list of modes In-Reply-To: <20200804023141.9510-1-sylphrenadin@gmail.com> Message-ID: References: <20200804023141.9510-1-sylphrenadin@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Aug 2020, Sumera Priyadarsini wrote: > This patch adds chain mode to the list of available modes in coccinelle. Thanks for the commit. In the log message, could you change "coccinelle" o "coccicheck"? Actually, the modes are not something that are built into Coccinelle. They are just implemented by the coccicheck script. thanks, julia > > Signed-off-by: Sumera Priyadarsini > --- > scripts/coccicheck | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index e04d328210ac..6e37cf36caae 100755 > --- a/scripts/coccicheck > +++ b/scripts/coccicheck > @@ -99,7 +99,7 @@ fi > if [ "$MODE" = "" ] ; then > if [ "$ONLINE" = "0" ] ; then > echo 'You have not explicitly specified the mode to use. Using default "report" mode.' > - echo 'Available modes are the following: patch, report, context, org' > + echo 'Available modes are the following: patch, report, context, org, chain' > echo 'You can specify the mode with "make coccicheck MODE="' > echo 'Note however that some modes are not implemented by some semantic patches.' > fi > -- > 2.17.1 > > _______________________________________________ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci >