From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65614C433E1 for ; Thu, 27 Aug 2020 20:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C0EC2071B for ; Thu, 27 Aug 2020 20:05:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbgH0UFO (ORCPT ); Thu, 27 Aug 2020 16:05:14 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:21081 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbgH0UFO (ORCPT ); Thu, 27 Aug 2020 16:05:14 -0400 X-IronPort-AV: E=Sophos;i="5.76,359,1592863200"; d="scan'208";a="357455363" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2020 22:05:11 +0200 Date: Thu, 27 Aug 2020 22:05:10 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Bartlomiej Zolnierkiewicz , Bernie Thompson , Denis Efremov , kernel test robot , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings In-Reply-To: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de> Message-ID: References: <13cd8bf4-06f9-04d7-e923-c397c506e8cc@web.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1007646674-1598558711=:2482" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1007646674-1598558711=:2482 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 27 Aug 2020, Markus Elfring wrote: > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > > > Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") > > I wonder about such a combination of information. > > I find it reasonable that two function implementations should be adjusted > according to a generated patch. > Thus I imagine that not the mentioned SmPL script is “fixed” > but the affected source file “drivers/video/fbdev/udlfb.c” may be improved. > Will the subject “[PATCH] video: udlfb: Fix kobj_to_dev.cocci warnings” > (or “[PATCH] video: udlfb: Use kobj_to_dev() instead of container_of()”) > be more appropriate for the proposed commit message? It seems that 0-day picks up new semantic patches that are added to trees in kernel.org, but that it's strategy for generating the patch is not ideal. I'll just drop these Fixes lines. julia --8323329-1007646674-1598558711=:2482--