From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89CC2C43461 for ; Tue, 8 Sep 2020 19:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A26B2166E for ; Tue, 8 Sep 2020 19:52:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732409AbgIHTwF (ORCPT ); Tue, 8 Sep 2020 15:52:05 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:8215 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730736AbgIHPth (ORCPT ); Tue, 8 Sep 2020 11:49:37 -0400 X-IronPort-AV: E=Sophos;i="5.76,359,1592863200"; d="scan'208";a="466596022" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 14:08:43 +0200 Date: Tue, 8 Sep 2020 14:08:43 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Bartlomiej Zolnierkiewicz cc: kernel test robot , Denis Efremov , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Daniel Vetter , Nathan Chancellor , Sam Ravnborg , Alex Deucher , Qiujun Huang , Peter Rosin , dri-devel@lists.freedesktop.org Subject: Re: [kbuild-all] Re: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings In-Reply-To: <3c266a0e-a2b9-ffde-0768-3b4fa89b0bfe@samsung.com> Message-ID: References: <202008101736.EtK0s7BQ%lkp@intel.com> <20200810092100.GA42813@2f5448a72a42> <3c266a0e-a2b9-ffde-0768-3b4fa89b0bfe@samsung.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Sep 2020, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On 8/10/20 11:21 AM, kernel test robot wrote: > > From: kernel test robot > > > > drivers/video/fbdev/core/fbcon.c:3509:8-16: WARNING: use scnprintf or sprintf > > drivers/video/fbdev/core/fbcon.c:3484:8-16: WARNING: use scnprintf or sprintf > > > > > > From Documentation/filesystems/sysfs.txt: > > show() must not use snprintf() when formatting the value to be > > returned to user space. If you can guarantee that an overflow > > will never happen you can use sprintf() otherwise you must use > > scnprintf(). > > > > Generated by: scripts/coccinelle/api/device_attr_show.cocci > > > > Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") > > CC: Denis Efremov > > Signed-off-by: kernel test robot > > --- > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > head: fc80c51fd4b23ec007e88d4c688f2cac1b8648e7 > > commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script > > > > Please take the patch only if it's a positive warning. Thanks! > > > > fbcon.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > --- a/drivers/video/fbdev/core/fbcon.c > > +++ b/drivers/video/fbdev/core/fbcon.c > > @@ -3481,7 +3481,7 @@ static ssize_t show_rotate(struct device > > rotate = fbcon_get_rotate(info); > > err: > > console_unlock(); > > - return snprintf(buf, PAGE_SIZE, "%d\n", rotate); > > + return scnprintf(buf, PAGE_SIZE, "%d\n", rotate); > > buf length is at least PAGE_SIZE and rotate val is an int so > shouldn't this be converted to use sprintf() instead? The rule is evolving in this direction. Thanks for the feedback. julia > > > } > > > > static ssize_t show_cursor_blink(struct device *device, > > @@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct > > blink = (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; > > err: > > console_unlock(); > > - return snprintf(buf, PAGE_SIZE, "%d\n", blink); > > + return scnprintf(buf, PAGE_SIZE, "%d\n", blink); > > ditto for blink val > > > } > > > > static ssize_t store_cursor_blink(struct device *device, > > > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org >