From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C65AC43461 for ; Wed, 9 Sep 2020 09:01:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27139206C9 for ; Wed, 9 Sep 2020 09:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729251AbgIIJBW (ORCPT ); Wed, 9 Sep 2020 05:01:22 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:58385 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbgIIJBV (ORCPT ); Wed, 9 Sep 2020 05:01:21 -0400 X-IronPort-AV: E=Sophos;i="5.76,359,1592863200"; d="scan'208";a="466743560" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2020 11:01:19 +0200 Date: Wed, 9 Sep 2020 11:01:18 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Sumera Priyadarsini , Coccinelle , Michal Marek , Gilles Muller , Nicolas Palix , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH v2] scripts: coccicheck: Do not use shift command when rule is specified In-Reply-To: <1a2ddefa-59dc-460c-59d5-5c6c1754d20b@web.de> Message-ID: References: <1a2ddefa-59dc-460c-59d5-5c6c1754d20b@web.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-688164862-1599642079=:2651" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-688164862-1599642079=:2651 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Wed, 9 Sep 2020, Markus Elfring wrote: > > Modify coccicheck to use the shift command only when > > number of shell arguments is not zero. > > I suggest to add the tag “Fixes” to the commit message. I don't think there is any need for that. This is not a patch that should be backported. The previous situation did not cause any problem with the execution of make coccicheck, only a tiresome warning message. julia > > > > Changes in V2: > > - Fix spelling errors as suggested by Markus Elfring > > Would you like to adjust the last word in the previous patch subject accordingly? > > Regards, > Markus > _______________________________________________ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci > --8323329-688164862-1599642079=:2651--