From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7883AC433E2 for ; Sun, 13 Sep 2020 20:15:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33EED20770 for ; Sun, 13 Sep 2020 20:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725969AbgIMUMF (ORCPT ); Sun, 13 Sep 2020 16:12:05 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11782 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbgIMUME (ORCPT ); Sun, 13 Sep 2020 16:12:04 -0400 X-IronPort-AV: E=Sophos;i="5.76,359,1592863200"; d="scan'208";a="467425457" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2020 22:12:02 +0200 Date: Sun, 13 Sep 2020 22:12:02 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Sumera Priyadarsini cc: linux-kernel@vger.kernel.org, michal.lkml@markovi.net, nicolas.palix@imag.fr, cocci@systeme.lip6.fr, Gilles.Muller@lip6.fr Subject: Re: [Cocci] [RFC PATCH] scripts: coccicheck: Improve error feedback when coccicheck fails In-Reply-To: <20200913120548.bwl3elfl7ss66eyh@adolin> Message-ID: References: <20200913120548.bwl3elfl7ss66eyh@adolin> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 13 Sep 2020, Sumera Priyadarsini wrote: > Currently, coccicheck fails with only the message "coccicheck failed" > and the error code for the failure. To obtain the error logs, > one needs to specify a debug file using the DEBUG_FILE option. > > Modify coccicheck to display error logs when it crashes unless > DEBUG_FILE is set, in which case, the error logs are stored in > the specified debug file. Applied, thanks. julia > > Signed-off-by: Sumera Priyadarsini > --- > scripts/coccicheck | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/scripts/coccicheck b/scripts/coccicheck > index e04d328210ac..dbeafa21f359 100755 > --- a/scripts/coccicheck > +++ b/scripts/coccicheck > @@ -126,8 +126,14 @@ run_cmd_parmap() { > if [ $VERBOSE -ne 0 ] ; then > echo "Running ($NPROC in parallel): $@" > fi > - echo $@ >>$DEBUG_FILE > - $@ 2>>$DEBUG_FILE > + if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then > + echo $@>>$DEBUG_FILE > + $@ 2>>$DEBUG_FILE > + else > + echo $@ > + $@ 2>&1 > + fi > + > err=$? > if [[ $err -ne 0 ]]; then > echo "coccicheck failed" > -- > 2.25.1 > > _______________________________________________ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci >