From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Sumera Priyadarsini <sylphrenadin@gmail.com>,
Coccinelle <cocci@systeme.lip6.fr>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [RFC PATCH] scripts: coccicheck: Improve error feedback when coccicheck fails
Date: Mon, 14 Sep 2020 09:14:09 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2009140913480.2357@hadrien> (raw)
In-Reply-To: <287a8c82-6359-9a7e-c2ca-d26aa5be9650@web.de>
On Mon, 14 Sep 2020, Markus Elfring wrote:
> >> How do you think about to use the following check variant?
> >>
> >> + if [ "${DEBUG_FILE}" != '/dev/null' -a "${DEBUG_FILE}" != '' ]; then
> >
> > What difference does it make?
>
> I propose two implementation details for further development considerations.
>
> 1. Do you care if any variable names should be enclosed by curly brackets
> in such script code?
>
> 2. A changeable value should be compared to two string literals here.
> Varying contents should be enclosed by double quotes.
> Constant values can be enclosed by single quotes, can't they?
I have no idea. Why can't they be nclosed by double quotes as well?
julia
next prev parent reply other threads:[~2020-09-14 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <44ab7442-1473-f267-4487-af98631a9338@web.de>
2020-09-14 6:21 ` Julia Lawall
[not found] ` <287a8c82-6359-9a7e-c2ca-d26aa5be9650@web.de>
2020-09-14 7:14 ` Julia Lawall [this message]
[not found] ` <e5d90bca-c264-c154-25ad-5046ac00b3e8@web.de>
2020-09-14 7:26 ` Julia Lawall
2020-09-13 12:05 Sumera Priyadarsini
2020-09-13 20:12 ` [Cocci] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2009140913480.2357@hadrien \
--to=julia.lawall@inria.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=sylphrenadin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®