From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A3A4C41604 for ; Sat, 3 Oct 2020 20:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CE17206C1 for ; Sat, 3 Oct 2020 20:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725919AbgJCUJj (ORCPT ); Sat, 3 Oct 2020 16:09:39 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:13686 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbgJCUJi (ORCPT ); Sat, 3 Oct 2020 16:09:38 -0400 X-IronPort-AV: E=Sophos;i="5.77,333,1596492000"; d="scan'208";a="470813160" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2020 22:09:36 +0200 Date: Sat, 3 Oct 2020 22:09:36 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Denis Efremov cc: Julia Lawall , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Kees Cook , "Gustavo A . R . Silva" Subject: Re: [PATCH v3] coccinelle: misc: add flexible_array.cocci script In-Reply-To: <20200921174920.87241-1-efremov@linux.com> Message-ID: References: <20200806220342.25426-1-efremov@linux.com> <20200921174920.87241-1-efremov@linux.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Sep 2020, Denis Efremov wrote: > One-element and zero-length arrays are deprecated [1]. Kernel > code should always use "flexible array members" instead, except > for existing uapi definitions. > > The script warns about one-element and zero-length arrays in structs. > > [1] commit 68e4cd17e218 ("docs: deprecated.rst: Add zero-length and > one-element arrays") > > Cc: Kees Cook > Cc: Gustavo A. R. Silva > Signed-off-by: Denis Efremov Applied, thanks. > --- > Changes in v2: > - all uapi headers are now filtered-out. Unfortunately, coccinelle > doesn't provide structure names in Location.current_element. > For structures the field is always "something_else". Thus, there is > no easy way to create a list of existing structures in uapi headers > and suppress the warning only for them, but not for the newly added > uapi structures. > - The pattern doesn't require 2+ fields in a structure/union anymore. > Now it also checks single field structures/unions. > - The pattern simplified and now uses disjuction in array elements > (Thanks, Markus) > - Unions are removed from patch mode > - one-element arrays are removed from patch mode. Correct patch may > involve turning the array to a simple field instead of a flexible > array. > Changes in v3: > - exists removed from "depends on patch" > - position argument fixed in org mode > - link to the online documentation added to the warning message > > scripts/coccinelle/misc/flexible_array.cocci | 88 ++++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 scripts/coccinelle/misc/flexible_array.cocci > > diff --git a/scripts/coccinelle/misc/flexible_array.cocci b/scripts/coccinelle/misc/flexible_array.cocci > new file mode 100644 > index 000000000000..947fbaff82a9 > --- /dev/null > +++ b/scripts/coccinelle/misc/flexible_array.cocci > @@ -0,0 +1,88 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Zero-length and one-element arrays are deprecated, see > +/// Documentation/process/deprecated.rst > +/// Flexible-array members should be used instead. > +/// > +// > +// Confidence: High > +// Copyright: (C) 2020 Denis Efremov ISPRAS. > +// Comments: > +// Options: --no-includes --include-headers > + > +virtual context > +virtual report > +virtual org > +virtual patch > + > +@initialize:python@ > +@@ > +def relevant(positions): > + for p in positions: > + if "uapi" in p.file: > + return False > + return True > + > +@r depends on !patch@ > +identifier name, array; > +type T; > +position p : script:python() { relevant(p) }; > +@@ > + > +( > + struct name { > + ... > +* T array@p[\(0\|1\)]; > + }; > +| > + struct { > + ... > +* T array@p[\(0\|1\)]; > + }; > +| > + union name { > + ... > +* T array@p[\(0\|1\)]; > + }; > +| > + union { > + ... > +* T array@p[\(0\|1\)]; > + }; > +) > + > +@depends on patch@ > +identifier name, array; > +type T; > +position p : script:python() { relevant(p) }; > +@@ > + > +( > + struct name { > + ... > + T array@p[ > +- 0 > + ]; > + }; > +| > + struct { > + ... > + T array@p[ > +- 0 > + ]; > + }; > +) > + > +@script: python depends on report@ > +p << r.p; > +@@ > + > +msg = "WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)" > +coccilib.report.print_report(p[0], msg) > + > +@script: python depends on org@ > +p << r.p; > +@@ > + > +msg = "WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)" > +coccilib.org.print_todo(p[0], msg) > -- > 2.26.2 > >