From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C901C388F7 for ; Thu, 22 Oct 2020 13:47:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDCF6221FB for ; Thu, 22 Oct 2020 13:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2900438AbgJVNrK (ORCPT ); Thu, 22 Oct 2020 09:47:10 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:41634 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2900350AbgJVNrK (ORCPT ); Thu, 22 Oct 2020 09:47:10 -0400 X-IronPort-AV: E=Sophos;i="5.77,404,1596492000"; d="scan'208";a="473874482" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 15:47:08 +0200 Date: Thu, 22 Oct 2020 15:47:08 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Izabela Bakollari cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] staging/wlan-ng: Fix line that exceeds 100 columns In-Reply-To: <20201022130807.212454-1-izabela.bakollari@gmail.com> Message-ID: References: <20201022130807.212454-1-izabela.bakollari@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Oct 2020, izabela.bakollari@gmail.com wrote: > From: Izabela Bakollari > > Rearrange comment that exceeds 100 columns length. Issue reported > by checkpatch.pl > > Signed-off-by: Izabela Bakollari > --- > drivers/staging/wlan-ng/cfg80211.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c > index 759e475e303c..5fad37a49aa5 100644 > --- a/drivers/staging/wlan-ng/cfg80211.c > +++ b/drivers/staging/wlan-ng/cfg80211.c > @@ -366,7 +366,8 @@ static int prism2_scan(struct wiphy *wiphy, > msg2.beaconperiod.data, > ie_buf, > ie_len, > - (msg2.signal.data - 65536) * 100, /* Conversion to signed type */ > + (msg2.signal.data - 65536) * 100, > + /* Conversion to signed type */ I think that the comment is in the wrong place. GFP_KERNEL has to do with whether the allocation can wait in case of insufficient memory, and not with signed types. The signed type thing must be the argument before. Si it would be better to put the comment above that code. julia > GFP_KERNEL); > > if (!bss) { > -- > 2.18.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201022130807.212454-1-izabela.bakollari%40gmail.com. >