From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC80C388F7 for ; Thu, 22 Oct 2020 13:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1861521D43 for ; Thu, 22 Oct 2020 13:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S368044AbgJVNuX (ORCPT ); Thu, 22 Oct 2020 09:50:23 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:41860 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S367998AbgJVNuK (ORCPT ); Thu, 22 Oct 2020 09:50:10 -0400 X-IronPort-AV: E=Sophos;i="5.77,404,1596492000"; d="scan'208";a="473874968" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 15:50:08 +0200 Date: Thu, 22 Oct 2020 15:50:08 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Izabela Bakollari cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] staging/wlan-ng: Fix line alignment In-Reply-To: <20201022132218.235744-1-izabela.bakollari@gmail.com> Message-ID: References: <20201022132218.235744-1-izabela.bakollari@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Oct 2020, izabela.bakollari@gmail.com wrote: > From: Izabela Bakollari > > Fix code alignment. Issue reported by checkpatch.pl Try to find something other than "Fix" to describe what you have done. What kind of change have you made and why is it a good idea? > > Signed-off-by: Izabela Bakollari > --- > drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c > index a908ff301707..1bd36dc2b7ff 100644 > --- a/drivers/staging/wlan-ng/prism2mgmt.c > +++ b/drivers/staging/wlan-ng/prism2mgmt.c > @@ -1198,8 +1198,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) > if (wlandev->netdev->type == ARPHRD_ETHER) { > /* Save macport 0 state */ > result = hfa384x_drvr_getconfig16(hw, > - HFA384x_RID_CNFPORTTYPE, > - &hw->presniff_port_type); > + HFA384x_RID_CNFPORTTYPE, > + &hw->presniff_port_type); I think that the code was nicer before. Staying inside 80 characters is worth something, and having the arguments lined up with the ( seems lees important in this case. It could be a concern if the arguments eg ended up right under the function name, because that would be easy to misread, but that is not the case here. julia > if (result) { > netdev_dbg > (wlandev->netdev, > -- > 2.18.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201022132218.235744-1-izabela.bakollari%40gmail.com. >