From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Coccinelle <cocci@systeme.lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] Coccinelle: null: Optimise disjunctions in SmPL script “eno.cocci”
Date: Sun, 25 Oct 2020 19:56:54 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2010251955280.2714@hadrien> (raw)
In-Reply-To: <8f58a94e-b093-a587-c56a-a0ea0fc1f3ea@web.de>
On Sun, 25 Oct 2020, Markus Elfring wrote:
> >> This analysis result indicates a clear ranking for such function calls.
> >> Thus reorder the SmPL disjunction items according to their usage incidence.
> >
> > Did you actually test this before and after the change and see a
> > difference in performance?
>
> Would you become interested to configure a representative test environment
> for safe comparisons of corresponding run time characteristics
> of the affected software?
In what sense could the comparison possibly be unsafe?
Just use time and run spatch on whatever machine you want. It's not that
complicated.
> > On my laptop, I see absolutely no difference,
> > for the patch mode and for the context mode.
>
> Does such information trigger a desire to clarify involved aspects in more detail?
Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz
julia
next prev parent reply other threads:[~2020-10-25 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0d1575b0-ab37-663e-2464-278fd76280b5@web.de>
2020-10-25 18:28 ` [Cocci] [PATCH] " Julia Lawall
[not found] ` <8f58a94e-b093-a587-c56a-a0ea0fc1f3ea@web.de>
2020-10-25 18:56 ` Julia Lawall [this message]
[not found] ` <bee0c5df-8f28-ee9d-99e2-abbf84df76e6@web.de>
2020-10-25 20:27 ` [Cocci] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2010251955280.2714@hadrien \
--to=julia.lawall@inria.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®