From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A5DC388F7 for ; Sun, 25 Oct 2020 20:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B83D422265 for ; Sun, 25 Oct 2020 20:27:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1418693AbgJYU1b (ORCPT ); Sun, 25 Oct 2020 16:27:31 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:9629 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727925AbgJYU1a (ORCPT ); Sun, 25 Oct 2020 16:27:30 -0400 X-IronPort-AV: E=Sophos;i="5.77,417,1596492000"; d="scan'208";a="474226999" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2020 21:27:27 +0100 Date: Sun, 25 Oct 2020 21:27:27 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Coccinelle , Gilles Muller , Michal Marek , Nicolas Palix , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?UTF-8?Q?Re=3A_=5BCocci=5D_Coccinelle=3A_null=3A_Optimise_disj?= =?UTF-8?Q?unctions_in_SmPL_script_=E2=80=9Ceno=2Ecocci=E2=80=9D?= In-Reply-To: Message-ID: References: <0d1575b0-ab37-663e-2464-278fd76280b5@web.de> <8f58a94e-b093-a587-c56a-a0ea0fc1f3ea@web.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1179668747-1603657647=:2714" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1179668747-1603657647=:2714 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Sun, 25 Oct 2020, Markus Elfring wrote: > >> Would you become interested to configure a representative test environment > >> for safe comparisons of corresponding run time characteristics > >> of the affected software? > > > > In what sense could the comparison possibly be unsafe? > > * Our test systems are obviously different. > Thus concerns can be considered for reproducibility of test results > on other possible configurations. > > * We share only a tiny fraction of technical information which would probably > be needed for “benchmarks”. > > > > Just use time and run spatch on whatever machine you want. > > fring@Sonne:~/Projekte/Linux/next-patched> > elfring@Sonne:~/Projekte/Linux/next-patched> git checkout next-20201023 && XX=$(date) && time spatch -D patch --timeout 9 --jobs 4 --chunksize 1 --include-headers --no-includes --dir . scripts/coccinelle/null/eno.cocci > ~/Projekte/Bau/Linux/scripts/Coccinelle/call_checks/20201023/eno1.diff 2> ~/Projekte/Bau/Linux/scripts/Coccinelle/call_checks/20201023/eno1-errors.txt; YY=$(date) && echo "$XX | $YY" > … > real 2m54,266s > user 10m15,553s > sys 0m4,004s > So 25. Okt 20:53:56 CET 2020 | So 25. Okt 20:56:51 CET 2020 > elfring@Sonne:~/Projekte/Linux/next-patched> git checkout next-20201023 && XX=$(date) && time spatch -D context --timeout 9 --jobs 4 --chunksize 1 --include-headers --no-includes --dir . scripts/coccinelle/null/eno.cocci > ~/Projekte/Bau/Linux/scripts/Coccinelle/call_checks/20201023/eno2.txt 2> ~/Projekte/Bau/Linux/scripts/Coccinelle/call_checks/20201023/eno2-errors.txt; YY=$(date) && echo "$XX | $YY" > … > real 2m38,494s > user 9m39,364s > sys 0m4,094s > So 25. Okt 20:58:05 CET 2020 | So 25. Okt 21:00:44 CET 2020 > elfring@Sonne:~/Projekte/Linux/next-patched> git checkout optimise_disjunction_in_eno.cocci-1 && XX=$(date) && time spatch -D patch --timeout 9 --jobs 4 --chunksize 1 --include-headers --no-includes --dir . scripts/coccinelle/null/eno.cocci > ~/Projekte/Bau/Linux/scripts/Coccinelle/call_checks/20201023/eno3.diff 2> ~/Projekte/Bau/Linux/scripts/Coccinelle/call_checks/20201023/eno3-errors.txt; YY=$(date) && echo "$XX | $YY" > … > real 2m46,097s > user 10m15,467s > sys 0m3,984s > So 25. Okt 21:00:56 CET 2020 | So 25. Okt 21:03:42 CET 2020 > elfring@Sonne:~/Projekte/Linux/next-patched> git checkout optimise_disjunction_in_eno.cocci-1 && XX=$(date) && time spatch -D context --timeout 9 --jobs 4 --chunksize 1 --include-headers --no-includes --dir . scripts/coccinelle/null/eno.cocci > ~/Projekte/Bau/Linux/scripts/Coccinelle/call_checks/20201023/eno4.txt 2> ~/Projekte/Bau/Linux/scripts/Coccinelle/call_checks/20201023/eno4-errors.txt; YY=$(date) && echo "$XX | $YY" > … > real 2m41,472s > user 9m37,492s > sys 0m3,834s In the patch case, the user and system time are essentially identical. In the context case, the difference in user time is 2 seconds out of 9.5 minutes, 0.3%. In the patch case, the real time is a bit slower. But I believe that this is due to the time to read in the data from the file system. I also had a number like that, but the difference disappeared when I reran it afterwards, which meant running that case in the same conditions as the others. In the context case, the real time is slightly slower with your patch. So I see no compelling evidence for making the change. julia > So 25. Okt 21:03:56 CET 2020 | So 25. Okt 21:06:37 CET 2020 > > > > Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz > > AMD Phenom(tm) II X4 850 Processor > > Will any other aspects become relevant? > > Regards, > Markus > --8323329-1179668747-1603657647=:2714--