From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C158C4363A for ; Tue, 27 Oct 2020 10:56:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30C5222282 for ; Tue, 27 Oct 2020 10:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2898789AbgJ0K4A (ORCPT ); Tue, 27 Oct 2020 06:56:00 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:14598 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2898762AbgJ0Kz5 (ORCPT ); Tue, 27 Oct 2020 06:55:57 -0400 X-IronPort-AV: E=Sophos;i="5.77,423,1596492000"; d="scan'208";a="362868559" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 11:55:53 +0100 Date: Tue, 27 Oct 2020 11:55:53 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Coccinelle , Gilles Muller , Masahiro Yamada , Michal Marek , Nicolas Palix , Sumera Priyadarsini , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?UTF-8?Q?Re=3A_=5BCocci=5D_Coccinelle=3A_Checking_the_relevanc?= =?UTF-8?Q?e_of_parentheses_in_=E2=80=9Cgit_grep=E2=80=9D?= In-Reply-To: <45310257-201a-40ea-348f-b8e909c3775c@web.de> Message-ID: References: <78f8b08754dde286adf7e11e1eeb3bb8ad500d8b.camel@web.de> <45310257-201a-40ea-348f-b8e909c3775c@web.de> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1797633343-1603796154=:2847" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1797633343-1603796154=:2847 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Tue, 27 Oct 2020, Markus Elfring wrote: > > Will any adjustments become relevant then accordingly? > > I have found out that the function “interpret” (OCaml code) constructs a command > and executes it. > https://github.com/coccinelle/coccinelle/blob/3c01dc1696dc5ccfb319673f205e491b572ee0be/parsing_cocci/git_grep.ml#L9 > > I have tried a corresponding test display out. Thus I have got the impression > that desired patterns are passed with extra parentheses. > > … git grep -l -w \( -e for_each_node_by_type … -e for_each_node_with_property \) -- '*.c' > > > How do you think about to omit these parentheses here? Does it make a difference? julia --8323329-1797633343-1603796154=:2847--