From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C00C55179 for ; Wed, 28 Oct 2020 21:48:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40E2D2064C for ; Wed, 28 Oct 2020 21:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727663AbgJ1VsF (ORCPT ); Wed, 28 Oct 2020 17:48:05 -0400 Received: from gentwo.org ([3.19.106.255]:34068 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbgJ1Vrw (ORCPT ); Wed, 28 Oct 2020 17:47:52 -0400 Received: by gentwo.org (Postfix, from userid 1002) id E4C6A3FCCF; Wed, 28 Oct 2020 11:11:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id E14743F7B6; Wed, 28 Oct 2020 11:11:20 +0000 (UTC) Date: Wed, 28 Oct 2020 11:11:20 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Laurent Dufour cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, nathanl@linux.ibm.com, cheloha@linux.ibm.com, mhocko@suse.com, Vlastimil Babka , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , stable@vger.kernel.org Subject: Re: [PATCH v2] mm/slub: fix panic in slab_alloc_node() In-Reply-To: <20201027190406.33283-1-ldufour@linux.ibm.com> Message-ID: References: <7ef64e75-2150-01a9-074d-a754348683b3@suse.cz> <20201027190406.33283-1-ldufour@linux.ibm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Oct 2020, Laurent Dufour wrote: > The issue is that object is not NULL while page is NULL which is odd but > may happen if the cache flush happened after loading object but before > loading page. Thus checking for the page pointer is required too. Ok then lets revert commit 6159d0f5c03e? The situation may occur elsewhere too.