From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495C1C433FE for ; Fri, 11 Dec 2020 20:00:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF2712311A for ; Fri, 11 Dec 2020 20:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405227AbgLKSYu (ORCPT ); Fri, 11 Dec 2020 13:24:50 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:64967 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404841AbgLKSYR (ORCPT ); Fri, 11 Dec 2020 13:24:17 -0500 X-IronPort-AV: E=Sophos;i="5.78,412,1599516000"; d="scan'208";a="367393133" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2020 19:23:32 +0100 Date: Fri, 11 Dec 2020 19:23:32 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Lukas Bulwahn cc: Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, Hannes Reinecke , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] block: drop dead assignments in loop_init() In-Reply-To: <20201211181236.25755-1-lukas.bulwahn@gmail.com> Message-ID: References: <20201211181236.25755-1-lukas.bulwahn@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Dec 2020, Lukas Bulwahn wrote: > Commit 8410d38c2552 ("loop: use __register_blkdev to allocate devices on > demand") simplified loop_init(); so computing the range of the block region > is not required anymore and can be dropped. > > Drop dead assignments in loop_init(). > > As compilers will detect these unneeded assignments and optimize this, > the resulting object code is identical before and after this change. > > No functional change. No change in object code. It looks like some braces should be dropped too? julia > > Signed-off-by: Lukas Bulwahn > --- > Christoph, please ack. > > Jens, please pick this minor non-urgent clean-up patch on your > block -next tree on top of Christoph's commit above. > > drivers/block/loop.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index d2ce1ddc192d..eed4bc5ef5c5 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -2304,7 +2304,6 @@ MODULE_ALIAS("devname:loop-control"); > static int __init loop_init(void) > { > int i, nr; > - unsigned long range; > struct loop_device *lo; > int err; > > @@ -2343,10 +2342,8 @@ static int __init loop_init(void) > */ > if (max_loop) { > nr = max_loop; > - range = max_loop << part_shift; > } else { > nr = CONFIG_BLK_DEV_LOOP_MIN_COUNT; > - range = 1UL << MINORBITS; > } > > err = misc_register(&loop_misc); > -- > 2.17.1 > >