From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 084F2C433DB for ; Wed, 6 Jan 2021 19:19:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B30702311B for ; Wed, 6 Jan 2021 19:19:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbhAFTTU (ORCPT ); Wed, 6 Jan 2021 14:19:20 -0500 Received: from gentwo.org ([3.19.106.255]:56954 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbhAFTTT (ORCPT ); Wed, 6 Jan 2021 14:19:19 -0500 X-Greylist: delayed 548 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Jan 2021 14:19:19 EST Received: by gentwo.org (Postfix, from userid 1002) id 02B783F551; Wed, 6 Jan 2021 19:09:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 007B53F550; Wed, 6 Jan 2021 19:09:25 +0000 (UTC) Date: Wed, 6 Jan 2021 19:09:25 +0000 (UTC) From: Christoph Lameter X-X-Sender: cl@www.lameter.com To: Vlastimil Babka cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Vladimir Davydov , Qian Cai , David Hildenbrand , Michal Hocko Subject: Re: [RFC 0/3] mm, slab, slub: remove cpu and memory hotplug locks In-Reply-To: <20210106174029.12654-1-vbabka@suse.cz> Message-ID: References: <20210106174029.12654-1-vbabka@suse.cz> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Jan 2021, Vlastimil Babka wrote: > rather accept some wasted memory in scenarios that should be rare anyway (full > memory hot remove), as we do the same in other contexts already. It's all RFC > for now, as I might have missed some reason why it's not safe. Looks good to me. My only concern is the kernel that has hotplug disabled. Current code allows the online/offline checks to be optimized away. Can this patch be enhanced to do the same?