From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 792D5C433B4 for ; Sat, 3 Apr 2021 21:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D2B36135C for ; Sat, 3 Apr 2021 21:16:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236814AbhDCVQW (ORCPT ); Sat, 3 Apr 2021 17:16:22 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:61576 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236725AbhDCVQV (ORCPT ); Sat, 3 Apr 2021 17:16:21 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3Apzj7MawzQ6d7AWD4XltsKrPx2uskLtp033Aq?= =?us-ascii?q?2lEZdDV+dMuEm8ey2MkKzBOcskdmZFgMkc2NUZPwP0/02JJx4ZYcJruuGDTh0V?= =?us-ascii?q?HYT71KwpDlx1TbalzD385bkZxtaq1vTOD3ZGIK//rSxQmjDpIAzNyfmZrGuc76?= =?us-ascii?q?z21xCSFmApsB0y5dChyHVnRxXhQuP/sEPb+d/NcCmz27ZX8MZN+6DXVtZYb+jv?= =?us-ascii?q?nqsL6jXhIcHR4g72C1/ESVwZrzEx2Z2RlbdjNU3N4ZnFTttwDi/K2sv7Wa53bn?= =?us-ascii?q?phzuxq1MlNHsx9dFDsDksKQoAw7hgAqpe4htMofq1Fte0YPfjSdP4aO832ZeA+?= =?us-ascii?q?1J53ncfn64rF/W4iaI6kdS11bYxVCVmnflq8DiLQhKfvZpv55TcRfS9iMbzaVB?= =?us-ascii?q?+Z9Mtljpx6Z/PFfikCP+59/TEzJtnSOP0DMfuN9WrHBZU4sYcvtroZYC+V49Ku?= =?us-ascii?q?ZJIAvKrLo/GO0rI8TV6p9tADWnRkGchHBmxJiIUms+G369MzA/k/3Q6SFfmDRC?= =?us-ascii?q?xU0CyKUk7w493aN4cYBN46D/L6x0iKsmdL5sUYtNQNgAWtesTlbGSRXKPG/6Gy?= =?us-ascii?q?WBKJ06?= X-IronPort-AV: E=Sophos;i="5.81,302,1610406000"; d="scan'208";a="501479224" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2021 23:16:16 +0200 Date: Sat, 3 Apr 2021 23:16:16 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Deborah Brouwer cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, insafonov@gmail.com, martin@kaiser.cx, simon.fodin@gmail.com, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: core: add comma within a comment In-Reply-To: <20210403210930.17781-1-deborahbrouwer3563@gmail.com> Message-ID: References: <20210403210930.17781-1-deborahbrouwer3563@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 3 Apr 2021, Deborah Brouwer wrote: > Add a comma to separate repeated words in a comment. The comma preserves > the meaning of the comment while also stopping the checkpatch warning: > WARNING: Possible repeated word: 'very'. Thanks. That is more understandable. Isn't this a v2? If so, there should be v2 after PATCH and an explanation of the change under the --- julia > > Signed-off-by: Deborah Brouwer > --- > drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c > index ed81cbc5e191..99e44b2c6f36 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c > +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c > @@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) > * If we turn on USE_RXTHREAD, then, no need for critical section. > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... > * > - * Must be very very cautious... > + * Must be very, very cautious... > * > */ > > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210403210930.17781-1-deborahbrouwer3563%40gmail.com. >