From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C651C433ED for ; Sat, 10 Apr 2021 10:02:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF4E561001 for ; Sat, 10 Apr 2021 10:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234634AbhDJKCX (ORCPT ); Sat, 10 Apr 2021 06:02:23 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:30475 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234377AbhDJKCS (ORCPT ); Sat, 10 Apr 2021 06:02:18 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AIXeaRaADPdMXYWflHeissceALOonbusQ8zAX?= =?us-ascii?q?/mp2TgFYddHdqtC2kJ0gpG7JoRsyeFVlo9CPP6GcXWjRnKQf3aA9NaqvNTOWx1?= =?us-ascii?q?eAAJp465D5hyDncheSysdzzqFlGpIOcuHYKFhhkILH5xOlGMwr29mN/MmT69v2?= =?us-ascii?q?61dIYUVUZ7p77wF/YzzraXFeYAVdH5I2GN69y6N8yAaIQngcYsSlCnRtZYGqze?= =?us-ascii?q?Hjr57+ZA5DOhhP0njzsRqS5KPnCB/d5x8CUlp0rYsKy3TPkADy+8yYwo+G4yLb?= =?us-ascii?q?vlWjkqh+qZ/EwttHCNfksKkoAwSpuxa6II9qXNS5zVIIidDq2UY41NLHvn4bTr?= =?us-ascii?q?xOwkKUT3Gn5RHrsjOQswoG2jvS2Uzdi2CLm6zEbQN/OtpTwYhFGyGpknYIjZVM?= =?us-ascii?q?wLEO03/xjesxMTrw2BXs9JzNWnhR5y+JiEtnoP4By3hQOLFuDIN5nMgv7FAQCZ?= =?us-ascii?q?VoJlOd1Lwa?= X-IronPort-AV: E=Sophos;i="5.82,210,1613430000"; d="scan'208";a="378277371" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2021 12:02:02 +0200 Date: Sat, 10 Apr 2021 12:02:02 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Greg KH cc: "Fabio M. De Francesco" , outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable In-Reply-To: Message-ID: References: <20210410092232.15155-1-fmdefrancesco@gmail.com> <20210410092232.15155-5-fmdefrancesco@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Apr 2021, Greg KH wrote: > On Sat, Apr 10, 2021 at 11:22:32AM +0200, Fabio M. De Francesco wrote: > > Change the type of fw_current_in_ps_mode from u8 to bool, because > > it is used everywhere as a bool and, accordingly, it should be > > declared as a bool. Shorten the controlling > > expression of an 'if' statement. > > > > Signed-off-by: Fabio M. De Francesco > > --- > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +- > > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c > > index 96fe172ced8d..8dc4dd8c6d4c 100644 > > --- a/drivers/staging/rtl8723bs/hal/hal_intf.c > > +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c > > @@ -348,7 +348,7 @@ void rtw_hal_dm_watchdog(struct adapter *padapter) > > > > void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter) > > { > > - if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode == true) { > > + if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode) { > > if (padapter->HalFunc.hal_dm_watchdog_in_lps) > > padapter->HalFunc.hal_dm_watchdog_in_lps(padapter); /* this function caller is in interrupt context */ > > } > > diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > > index 0a48f1653be5..0767dbb84199 100644 > > --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > > +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h > > @@ -203,7 +203,7 @@ struct pwrctrl_priv { > > u8 LpsIdleCount; > > u8 power_mgnt; > > u8 org_power_mgnt; > > - u8 fw_current_in_ps_mode; > > + bool fw_current_in_ps_mode; > > unsigned long DelayLPSLastTimeStamp; > > s32 pnp_current_pwr_state; > > u8 pnp_bstop_trx; > > If this is only checked, how can it ever be true? Who ever sets this > value? I think it's already updated everywhere with true and false, so there is nothing to change. But it would be good to make that clear in the log message. julia > > thanks, > > greg k-h > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHFwZCh%2Bs7ymrsQN%40kroah.com. >