From: Julia Lawall <julia.lawall@inria.fr>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable
Date: Sat, 10 Apr 2021 13:37:30 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2104101334190.2975@hadrien> (raw)
In-Reply-To: <10115279.QsZogQpAqX@localhost.localdomain>
> That variable has global scope and is assigned at least in:
What do you mean by global scope? None of the following look like
references to global variables.
julia
>
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:368:
> pwrpriv->fw_current_in_ps_mode = false;
>
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:380:
> pwrpriv->fw_current_in_ps_mode = true;
>
> drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:433:
> adapter_to_pwrctl(padapter)->fw_current_in_ps_mode = false;
>
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:981:
> pwrctrlpriv->fw_current_in_ps_mode = false;
next prev parent reply other threads:[~2021-04-10 11:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 9:22 [Outreachy kernel] [PATCH 0/4] staging: rtl8723bs: Change several files of the driver Fabio M. De Francesco
2021-04-10 9:22 ` [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files Fabio M. De Francesco
2021-04-10 9:32 ` Greg KH
2021-04-10 9:45 ` Fabio M. De Francesco
2021-04-10 10:32 ` Greg KH
2021-04-10 9:22 ` [Outreachy kernel] [PATCH 2/4] staging: rtl8723bs: include: Fix misspelled words in comments Fabio M. De Francesco
2021-04-10 9:22 ` [Outreachy kernel] [PATCH 3/4] staging: rtl8723bs: core: Remove an unused variable Fabio M. De Francesco
2021-04-10 9:22 ` [Outreachy kernel] [PATCH 4/4] staging: rtl8723bs: Change the type and use of a variable Fabio M. De Francesco
2021-04-10 9:31 ` Greg KH
2021-04-10 9:56 ` Fabio M. De Francesco
2021-04-10 10:31 ` Greg KH
2021-04-10 10:58 ` Fabio M. De Francesco
2021-04-10 11:03 ` Greg KH
2021-04-10 11:23 ` Fabio M. De Francesco
2021-04-10 11:33 ` Greg KH
2021-04-10 11:37 ` Julia Lawall [this message]
2021-04-10 12:01 ` Fabio M. De Francesco
2021-04-10 12:12 ` Julia Lawall
2021-04-10 13:02 ` Fabio M. De Francesco
2021-04-10 13:24 ` Julia Lawall
2021-04-10 13:53 ` Fabio M. De Francesco
2021-04-10 13:55 ` Greg KH
2021-04-10 14:01 ` Julia Lawall
2021-04-10 10:02 ` Julia Lawall
2021-04-10 10:03 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2104101334190.2975@hadrien \
--to=julia.lawall@inria.fr \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®