From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C50C433B4 for ; Mon, 26 Apr 2021 10:07:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4468611CE for ; Mon, 26 Apr 2021 10:07:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232965AbhDZKIG (ORCPT ); Mon, 26 Apr 2021 06:08:06 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:47212 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232249AbhDZKID (ORCPT ); Mon, 26 Apr 2021 06:08:03 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3ASQxsOaCOEXuyQ/PlHelN55DYdL4zR+YMi2QD?= =?us-ascii?q?/UZ3VBBTb4ikh9mj9c5rsSPcpT4NVBgb8uyoF7KHRRrnn6JdwY5UBru6WRmjhW?= =?us-ascii?q?3AFuBfxK/D5xGlJCHk7O5a0s5bAs1DIfn9F0Jzg8q/wCTQKbYd6eKK+qypmuvS?= =?us-ascii?q?pk0FJT1CUK1u4xx0DQyWCCRNNWp7LKAkH5mR7NcvnVSdUEkQB/7WOlA4ReTZ4/?= =?us-ascii?q?XEmJX6CCR2ZSIP2U2+yQml77P3CHGjsys2WTkn+9gfzVQ=3D?= X-IronPort-AV: E=Sophos;i="5.82,252,1613430000"; d="scan'208";a="379678700" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 12:07:20 +0200 Date: Mon, 26 Apr 2021 12:07:20 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: "Fabio M. De Francesco" cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Kershner , Greg Kroah-Hartman , Matthew Wilcox , Daniel Vetter Subject: Re: [Outreachy kernel] [RFC PATCH] staging: unisys: visorhba: Convert module from IDR to XArray In-Reply-To: <20210426095015.18556-1-fmdefrancesco@gmail.com> Message-ID: References: <20210426095015.18556-1-fmdefrancesco@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -273,8 +260,7 @@ static int forward_taskmgmt_command(enum task_mgmt_types tasktype, > if (devdata->serverdown || devdata->serverchangingstate) > return FAILED; > > - scsicmd_id = add_scsipending_entry(devdata, CMD_SCSITASKMGMT_TYPE, > - NULL); > + scsicmd_id = add_scsipending_entry(devdata, CMD_SCSITASKMGMT_TYPE, NULL); > if (scsicmd_id < 0) > return FAILED; > As far as I can see, this is just a whitespace change, so it shouldn't be in with the rest. If you make whitspace changes, they should be in with the other code that you are changing. julia