From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE17C433B4 for ; Tue, 11 May 2021 20:46:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9623616E8 for ; Tue, 11 May 2021 20:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbhEKUrh (ORCPT ); Tue, 11 May 2021 16:47:37 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:3640 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbhEKUrg (ORCPT ); Tue, 11 May 2021 16:47:36 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AuYLklK34YjRGGJPRg4wNbQqjBLkkLtp133Aq?= =?us-ascii?q?2lEZdPU1SL37qynApp8mPHPP4gr5O0tQ+uxoWpPgfZq0z/cc3WB7B9mftWfd1F?= =?us-ascii?q?dAYLsD0aLShwylISH4++JHvJ0MT4F1ArTLYmRHsQ=3D=3D?= X-IronPort-AV: E=Sophos;i="5.82,291,1613430000"; d="scan'208";a="507819115" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 May 2021 22:46:07 +0200 Date: Tue, 11 May 2021 22:46:07 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Julian Braha cc: Andrew Morton , Linux Memory Management List , linux-kernel@vger.kernel.org, kbuild-all@lists.01.org Subject: [PATCH] lib: fix for_each_child.cocci warnings Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot For_each_available_child_of_node should have of_node_put() before return around line 1121. Generated by: scripts/coccinelle/iterators/for_each_child.cocci Fixes: 7d37cb2c912d ("lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS") CC: Julian Braha Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1140ab592e2ebf8153d2b322604031a8868ce7a5 commit: 7d37cb2c912dc5c25ffac784a4f9b98c06c6bd08 lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS :::::: branch date: 15 hours ago :::::: commit date: 5 weeks ago mcde_dsi.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/mcde/mcde_dsi.c +++ b/drivers/gpu/drm/mcde/mcde_dsi.c @@ -1118,6 +1118,7 @@ static int mcde_dsi_bind(struct device * bridge = of_drm_find_bridge(child); if (!bridge) { dev_err(dev, "failed to find bridge\n"); + of_node_put(child); return -EINVAL; } }