From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE56C4743C for ; Mon, 21 Jun 2021 18:47:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B9DF6124B for ; Mon, 21 Jun 2021 18:47:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232323AbhFUSt5 (ORCPT ); Mon, 21 Jun 2021 14:49:57 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:58727 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232329AbhFUSty (ORCPT ); Mon, 21 Jun 2021 14:49:54 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AFTM8E6/U+dPHV242oeZuk+DEI+orL9Y04lQ7?= =?us-ascii?q?vn2ZKCYlEPBw+PrAoB1273HJYVUqKRIdcLK7WZVoKEm0nfVICOIqUItKMjONhI?= =?us-ascii?q?LRFuFfBV2L+VHdJxE=3D?= X-IronPort-AV: E=Sophos;i="5.83,289,1616454000"; d="scan'208";a="515895312" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2021 20:47:38 +0200 Date: Mon, 21 Jun 2021 20:47:38 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Denis Efremov cc: Keith Busch , linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe Subject: Re: [PATCH] coccinelle: api: remove kobj_to_dev.cocci script In-Reply-To: Message-ID: References: <20210621174808.1489111-1-kbusch@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Jun 2021, Denis Efremov wrote: > > > On 6/21/21 8:48 PM, Keith Busch wrote: > > Using kobj_to_dev() instead of container_of() is not universally > > accepted among maintainers as an improvement. The warning leads to > > repeated patch submissions that won't be accepted. Remove the script. > > > > Cc: Christoph Hellwig > > Cc: Jens Axboe > > Cc: Denis Efremov > > Cc: Julia Lawall > > Signed-off-by: Keith Busch > > Acked-by: Denis Efremov Applied. > > > --- > > scripts/coccinelle/api/kobj_to_dev.cocci | 45 ------------------------ > > 1 file changed, 45 deletions(-) > > delete mode 100644 scripts/coccinelle/api/kobj_to_dev.cocci > > > > diff --git a/scripts/coccinelle/api/kobj_to_dev.cocci b/scripts/coccinelle/api/kobj_to_dev.cocci > > deleted file mode 100644 > > index cd5d31c6fe76..000000000000 > > --- a/scripts/coccinelle/api/kobj_to_dev.cocci > > +++ /dev/null > > @@ -1,45 +0,0 @@ > > -// SPDX-License-Identifier: GPL-2.0-only > > -/// > > -/// Use kobj_to_dev() instead of container_of() > > -/// > > -// Confidence: High > > -// Copyright: (C) 2020 Denis Efremov ISPRAS > > -// Options: --no-includes --include-headers > > -// > > -// Keywords: kobj_to_dev, container_of > > -// > > - > > -virtual context > > -virtual report > > -virtual org > > -virtual patch > > - > > - > > -@r depends on !patch@ > > -expression ptr; > > -symbol kobj; > > -position p; > > -@@ > > - > > -* container_of(ptr, struct device, kobj)@p > > - > > - > > -@depends on patch@ > > -expression ptr; > > -@@ > > - > > -- container_of(ptr, struct device, kobj) > > -+ kobj_to_dev(ptr) > > - > > - > > -@script:python depends on report@ > > -p << r.p; > > -@@ > > - > > -coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()") > > - > > -@script:python depends on org@ > > -p << r.p; > > -@@ > > - > > -coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()") > > >