From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B689C433EF for ; Mon, 6 Sep 2021 07:39:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 238EE60E8B for ; Mon, 6 Sep 2021 07:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240178AbhIFHk3 (ORCPT ); Mon, 6 Sep 2021 03:40:29 -0400 Received: from mga05.intel.com ([192.55.52.43]:14969 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239974AbhIFHk1 (ORCPT ); Mon, 6 Sep 2021 03:40:27 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10098"; a="305469643" X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="305469643" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2021 00:39:04 -0700 X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="536560328" Received: from eliteleevi.tm.intel.com ([10.237.54.20]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2021 00:39:01 -0700 Date: Mon, 6 Sep 2021 10:32:32 +0300 (EEST) From: Kai Vehmanen X-X-Sender: kvehmane@eliteleevi.tm.intel.com To: Kai-Heng Feng cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, David Airlie , Daniel Vetter , =?ISO-8859-15?Q?Ville_Syrj=E4l=E4?= , Lucas De Marchi , Imre Deak , Uma Shankar , Matt Roper , Kai Vehmanen , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915/audio: Use BIOS provided value for RKL HDA link In-Reply-To: <20210906041300.508458-1-kai.heng.feng@canonical.com> Message-ID: References: <20210906041300.508458-1-kai.heng.feng@canonical.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7 02160 Espoo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, 6 Sep 2021, Kai-Heng Feng wrote: > Commit 989634fb49ad ("drm/i915/audio: set HDA link parameters in > driver") makes HDMI audio on Lenovo P350 disappear. > > So in addition to TGL, extend the logic to RKL to use BIOS provided > value to fix the regression. thanks Kai-Heng! We were not aware of commercial RKL systems following the old BIOS guidance, but given you just hit one, then this definitely is needed: Reviewed-by: Kai Vehmanen Br, Kai