From: Julia Lawall <julia.lawall@inria.fr>
To: Jens Axboe <axboe@kernel.dk>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [axboe-block:for-5.18/io_uring 19/25] fs/io_uring.c:4338:42-56: duplicated argument to && or || (fwd)
Date: Sat, 12 Mar 2022 14:41:34 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2203121440550.18925@hadrien> (raw)
sqe->buf_index appears twice.
---------- Forwarded message ----------
Date: Sat, 12 Mar 2022 03:22:42 +0800
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Cc: lkp@intel.com, Julia Lawall <julia.lawall@lip6.fr>
Subject: [axboe-block:for-5.18/io_uring 19/25] fs/io_uring.c:4338:42-56:
duplicated argument to && or ||
CC: kbuild-all@lists.01.org
BCC: lkp@intel.com
CC: linux-kernel@vger.kernel.org
TO: Jens Axboe <axboe@kernel.dk>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-5.18/io_uring
head: bcbb7bf6ccde7cb969a5642879832bc84ebf06a3
commit: 4f57f06ce2186c31c3da52386125dc57b1cd6f96 [19/25] io_uring: add support for IORING_OP_MSG_RING command
:::::: branch date: 23 hours ago
:::::: commit date: 27 hours ago
config: csky-randconfig-c004-20220310 (https://download.01.org/0day-ci/archive/20220312/202203120306.eNEnYxKX-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> fs/io_uring.c:4338:42-56: duplicated argument to && or ||
vim +4338 fs/io_uring.c
2b188cc1bb857a Jens Axboe 2019-01-07 4334
4f57f06ce2186c Jens Axboe 2022-03-10 4335 static int io_msg_ring_prep(struct io_kiocb *req,
4f57f06ce2186c Jens Axboe 2022-03-10 4336 const struct io_uring_sqe *sqe)
4f57f06ce2186c Jens Axboe 2022-03-10 4337 {
4f57f06ce2186c Jens Axboe 2022-03-10 @4338 if (unlikely(sqe->addr || sqe->ioprio || sqe->buf_index ||
4f57f06ce2186c Jens Axboe 2022-03-10 4339 sqe->rw_flags || sqe->splice_fd_in || sqe->buf_index ||
4f57f06ce2186c Jens Axboe 2022-03-10 4340 sqe->personality))
4f57f06ce2186c Jens Axboe 2022-03-10 4341 return -EINVAL;
4f57f06ce2186c Jens Axboe 2022-03-10 4342
4f57f06ce2186c Jens Axboe 2022-03-10 4343 if (req->file->f_op != &io_uring_fops)
4f57f06ce2186c Jens Axboe 2022-03-10 4344 return -EBADFD;
4f57f06ce2186c Jens Axboe 2022-03-10 4345
4f57f06ce2186c Jens Axboe 2022-03-10 4346 req->msg.user_data = READ_ONCE(sqe->off);
4f57f06ce2186c Jens Axboe 2022-03-10 4347 req->msg.len = READ_ONCE(sqe->len);
4f57f06ce2186c Jens Axboe 2022-03-10 4348 return 0;
4f57f06ce2186c Jens Axboe 2022-03-10 4349 }
4f57f06ce2186c Jens Axboe 2022-03-10 4350
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next reply other threads:[~2022-03-12 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 13:41 Julia Lawall [this message]
2022-03-12 13:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2203121440550.18925@hadrien \
--to=julia.lawall@inria.fr \
--cc=axboe@kernel.dk \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®