From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D376C433F5 for ; Thu, 7 Apr 2022 04:06:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234134AbiDGEIi (ORCPT ); Thu, 7 Apr 2022 00:08:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbiDGEIf (ORCPT ); Thu, 7 Apr 2022 00:08:35 -0400 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 649B958E67 for ; Wed, 6 Apr 2022 21:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=uEn8UB6EoN5i4tOmH0BcPmL+HvFT8NPS6yteEp9T7Zg=; b=HJv7rWR5JCTiUN/EfuoKq8HRPPC8lHW7KH03xjUP86pBHGYDqNKHB7CV vAALmDgW/ySknC/Hp1yJTDBr+LU5qJxfs1QdLPfRlRabqvXDsEpmuLsP/ Uq2bh0yGLvDBnGp0Z3ekDmnVP6ruAGXX6OI+NXJervE4tffBVeBq0Vf0V E=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.90,241,1643670000"; d="scan'208";a="10799962" Received: from lputeaux-656-1-153-249.w217-128.abo.wanadoo.fr (HELO hadrien) ([217.128.47.249]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 06:06:35 +0200 Date: Thu, 7 Apr 2022 06:06:33 +0200 (CEST) From: Julia Lawall X-X-Sender: julia@hadrien To: Alaa Mohamed cc: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: rtl8712: remove unnecessary parentheses In-Reply-To: <20220406224057.5260-1-eng.alaamohamedsoliman.am@gmail.com> Message-ID: References: <20220406224057.5260-1-eng.alaamohamedsoliman.am@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 Apr 2022, Alaa Mohamed wrote: > Reported by checkpatch: > > CHECK: Unnecessary parentheses around param->u.crypt.key[16]: 85 > CHECK: Unnecessary parentheses around param->u.crypt.key[24]: 87 > CHECK: Unnecessary parentheses around padapter->mlmepriv: 603 > CHECK: Unnecessary parentheses around wrqu->encoding: 1497 > CHECK: Unnecessary parentheses around wrqu->encoding: 1592 > CHECK: Unnecessary parentheses around padapter->mlmepriv: 1593 > CHECK: Unnecessary parentheses around wrqu->param: 1673 > CHECK: Unnecessary parentheses around pmlmepriv->scanned_queue.lock: 1967 > CHECK: Unnecessary parentheses around pmlmepriv->scanned_queue.lock: 1977 > CHECK: Unnecessary parentheses around pmlmepriv->scanned_queue.lock: 1999 This still needs to be improved. > Signed-off-by: Alaa Mohamed > --- > Changes in v2: > - Edit commit subject > - Edit commit message > - Fix the same check in more lines > - Remove space before '.skey' in > "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86. > --- > Changes in v3: > return the space before '.skey' in > "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86 Thanks for taking care of this part. julia > --- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 20 +++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > index 3b6926613257..f1e352b7f83e 100644 > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > @@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *psta, > (param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len)); > if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */ > memcpy(psta->tkiptxmickey. skey, > - &(param->u.crypt.key[16]), 8); > + ¶m->u.crypt.key[16], 8); > memcpy(psta->tkiprxmickey. skey, > - &(param->u.crypt.key[24]), 8); > + ¶m->u.crypt.key[24], 8); > padapter->securitypriv. busetkipkey = false; > mod_timer(&padapter->securitypriv.tkip_timer, > jiffies + msecs_to_jiffies(50)); > @@ -600,7 +600,7 @@ static int r8711_wx_get_name(struct net_device *dev, > u32 ht_ielen = 0; > char *p; > u8 ht_cap = false; > - struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); > + struct mlme_priv *pmlmepriv = &padapter->mlmepriv; > struct wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network; > u8 *prates; > > @@ -1494,7 +1494,7 @@ static int r8711_wx_set_enc(struct net_device *dev, > u32 keyindex_provided; > struct NDIS_802_11_WEP wep; > enum NDIS_802_11_AUTHENTICATION_MODE authmode; > - struct iw_point *erq = &(wrqu->encoding); > + struct iw_point *erq = &wrqu->encoding; > struct _adapter *padapter = netdev_priv(dev); > > key = erq->flags & IW_ENCODE_INDEX; > @@ -1589,8 +1589,8 @@ static int r8711_wx_get_enc(struct net_device *dev, > { > uint key; > struct _adapter *padapter = netdev_priv(dev); > - struct iw_point *erq = &(wrqu->encoding); > - struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); > + struct iw_point *erq = &wrqu->encoding; > + struct mlme_priv *pmlmepriv = &padapter->mlmepriv; > union Keytype *dk = padapter->securitypriv.DefKey; > > if (!check_fwstate(pmlmepriv, _FW_LINKED)) { > @@ -1670,7 +1670,7 @@ static int r871x_wx_set_auth(struct net_device *dev, > union iwreq_data *wrqu, char *extra) > { > struct _adapter *padapter = netdev_priv(dev); > - struct iw_param *param = (struct iw_param *)&(wrqu->param); > + struct iw_param *param = (struct iw_param *)&wrqu->param; > int paramid; > int paramval; > int ret = 0; > @@ -1964,7 +1964,7 @@ static int r871x_get_ap_info(struct net_device *dev, > return -EINVAL; > data[32] = 0; > > - spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL); > + spin_lock_irqsave(&pmlmepriv->scanned_queue.lock, irqL); > phead = &queue->queue; > plist = phead->next; > while (1) { > @@ -1974,7 +1974,7 @@ static int r871x_get_ap_info(struct net_device *dev, > if (!mac_pton(data, bssid)) { > netdev_info(dev, "r8712u: Invalid BSSID '%s'.\n", > (u8 *)data); > - spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), > + spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, > irqL); > return -EINVAL; > } > @@ -1996,7 +1996,7 @@ static int r871x_get_ap_info(struct net_device *dev, > } > plist = plist->next; > } > - spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), irqL); > + spin_unlock_irqrestore(&pmlmepriv->scanned_queue.lock, irqL); > if (pdata->length >= 34) { > if (copy_to_user((u8 __user *)pdata->pointer + 32, > (u8 *)&pdata->flags, 1)) > -- > 2.35.1 > > >