From: Julia Lawall <julia.lawall@inria.fr>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Mahak Gupta <mahak_g@cs.iitr.ac.in>,
Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: r8188eu: remove else after return and break statements
Date: Wed, 13 Apr 2022 11:02:58 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2204131102300.3470@hadrien> (raw)
In-Reply-To: <4946ce95-8692-b765-b5ea-ab4b521182fc@gmail.com>
On Wed, 13 Apr 2022, Pavel Skripkin wrote:
> Hi Mahak,
>
> On 4/13/22 08:27, Mahak Gupta wrote:
> > Else is not necessary after return and break statements, hence remove
> > it.
> >
> > Reported by checkpatch:
> >
> > WARNING: else is not generally useful after a break or return
> >
> > Signed-off-by: Mahak Gupta <mahak_g@cs.iitr.ac.in>
>
> [snip]
>
> > - }
> > + /* could be pure B, pure G, or B/G */
> > + if (rtw_is_cckratesonly_included(rate))
> > + return WIRELESS_11B;
> > + else if (rtw_is_cckrates_included(rate))
> > + return WIRELESS_11BG;
> > + else
> > + return WIRELESS_11G;
>
> This 'else' is after 'return' as well, isn't it? Just wondering what's the
> difference between this one and others in this patch
Maybe it's nice to have the three options lined up?
julia
next prev parent reply other threads:[~2022-04-13 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 5:27 Mahak Gupta
2022-04-13 8:52 ` Pavel Skripkin
2022-04-13 9:02 ` Julia Lawall [this message]
2022-04-13 16:51 ` Larry Finger
2022-04-14 22:01 ` MAHAK GUPTA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2204131102300.3470@hadrien \
--to=julia.lawall@inria.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mahak_g@cs.iitr.ac.in \
--cc=outreachy@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®