From: matthew.gerlach@linux.intel.com
To: Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, dinguyen@vger.kernel.org,
robh+dt@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH] arm64: dts: intel: add device tree for n6000
Date: Mon, 2 May 2022 12:04:05 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2205021157040.65759@rhweight-WRK1> (raw)
In-Reply-To: <CAL_JsqKwr7Je51X=OVd5Mfxe=Ztvp7jY2WcTu+treB3x7QBxfA@mail.gmail.com>
On Mon, 2 May 2022, Rob Herring wrote:
> On Mon, May 2, 2022 at 11:58 AM <matthew.gerlach@linux.intel.com> wrote:
>>
>> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>>
>> Add a device tree for the n6000 instantiation of Agilex
>> Hard Processor System (HPS).
>>
>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>> ---
>> arch/arm64/boot/dts/intel/Makefile | 1 +
>> .../boot/dts/intel/socfpga_agilex_n6000.dts | 77 +++++++++++++++++++
>> 2 files changed, 78 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
>>
>> diff --git a/arch/arm64/boot/dts/intel/Makefile b/arch/arm64/boot/dts/intel/Makefile
>> index 0b5477442263..1425853877cc 100644
>> --- a/arch/arm64/boot/dts/intel/Makefile
>> +++ b/arch/arm64/boot/dts/intel/Makefile
>> @@ -1,5 +1,6 @@
>> # SPDX-License-Identifier: GPL-2.0-only
>> dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_socdk.dtb \
>> socfpga_agilex_socdk_nand.dtb \
>> + socfpga_agilex_n6000.dtb \
>
> Alphabetical order.
Got it.
>
>> socfpga_n5x_socdk.dtb
>> dtb-$(CONFIG_ARCH_KEEMBAY) += keembay-evm.dtb
>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
>> new file mode 100644
>> index 000000000000..07f5a5983e5c
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
>> @@ -0,0 +1,77 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2021-2022, Intel Corporation
>> + */
>> +#include "socfpga_agilex.dtsi"
>> +
>> +/ {
>> + model = "SoCFPGA Agilex n6000";
>> +
>> + aliases {
>> + serial0 = &uart1;
>> + serial1 = &uart0;
>> + ethernet0 = &gmac0;
>> + ethernet1 = &gmac1;
>> + ethernet2 = &gmac2;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial0:115200n8";
>> + };
>> +
>> + memory {
>> + device_type = "memory";
>> + /* We expect the bootloader to fill in the reg */
>> + reg = <0 0 0 0>;
>> + };
>> +
>> + soc {
>> + clocks {
>> + osc1 {
>> + clock-frequency = <25000000>;
>> + };
>> + };
>> + agilex_hps_bridges: bridge@80000000 {
>> + compatible = "simple-bus";
>> + reg = <0x80000000 0x60000000>,
>> + <0xf9000000 0x00100000>;
>> + reg-names = "axi_h2f", "axi_h2f_lw";
>> + #address-cells = <0x2>;
>> + #size-cells = <0x1>;
>> + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>;
>> +
>> + uio_cp_eng@0xf9000000 {
>
> Unit addresses shouldn't have '0x' and the address is wrong as it
> should match the child address (0). dtc will tell you this though you
> need 'W=1'. Run this and schema checks and don't add new warnings.
Thanks for the pointers. I will run with W=1 and run schema checks and
submit a v2.
>
>> + compatible = "generic-uio";
>
> NAK. Not documented and that's because this is not a h/w device.
Got it. I will create a meaningful name for the h/w device and submit
documentation.
>
>> + reg = <0x00000000 0x00000000 0x00001000>;
>> + status = "okay";
>
> That's the default.
I will remove redundant status field.
>
>> + };
>> + };
>> + };
>> +};
>> +
>> +&uart0 {
>> + status = "okay";
>> +};
>> +
>> +&uart1 {
>> + status = "okay";
>> +};
>> +
>> +&spi0 {
>> + status = "okay";
>> +
>> + spidev: spidev@0 {
>> + status = "okay";
>> + compatible = "linux,spidev";
>> + spi-max-frequency = <25000000>;
>> + reg = <0>;
>> + };
>> +};
>> +
>> +&watchdog0 {
>> + status = "okay";
>> +};
>> +
>> +&fpga_mgr {
>> + status = "disabled";
>> +};
>> --
>> 2.25.1
>>
>
next prev parent reply other threads:[~2022-05-02 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 16:58 matthew.gerlach
2022-05-02 17:12 ` Rob Herring
2022-05-02 19:04 ` matthew.gerlach [this message]
2022-05-03 12:23 ` Krzysztof Kozlowski
2022-05-03 14:35 ` matthew.gerlach
2022-05-03 12:24 ` Krzysztof Kozlowski
2022-05-03 12:55 ` Krzysztof Kozlowski
2022-05-03 14:38 ` matthew.gerlach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2205021157040.65759@rhweight-WRK1 \
--to=matthew.gerlach@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®