From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2CC4C433EF for ; Thu, 5 May 2022 17:17:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382617AbiEERUk (ORCPT ); Thu, 5 May 2022 13:20:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244119AbiEERUh (ORCPT ); Thu, 5 May 2022 13:20:37 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84A4C5C767; Thu, 5 May 2022 10:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651771017; x=1683307017; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=PxnyMBD8J7Ko5aqaji0GRDRAx0pTIu0hTbfyHUGWdLI=; b=PhVTGMlx6ac5fJdUa433bnUj+GGVLJtTuzW0TmLi4ELSZMJcGpgnl2t4 08NyFq7W65R3OTTKdT07uBKq7hhyN+ytIcFOdb1buFaG9xI+xlSbwi+QU CihpA6RxuVvWJBxDhkT8rgCDUTPx/aDvoeicCUer+iYISW38feLLP/lcH CNUsngchkBvpSKVRbMUeFWdaoSeNV8U0V7OIgB3DYLan8jJsHrDgZnLcP tcq7VP5psapbK7ChirgU2e9C3wTKf6PS4/ePex6NJslCx3dfuSsVQ10Zu Rr65a6G2ZN/wRNurPylXGzWAT7RSBPsJQtSLWov10p5hNGf/LpYc48/KI Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="267788952" X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="267788952" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 10:16:57 -0700 X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="585453058" Received: from rhweight-wrk1.ra.intel.com ([137.102.106.43]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 10:16:57 -0700 Date: Thu, 5 May 2022 10:16:50 -0700 (PDT) From: matthew.gerlach@linux.intel.com X-X-Sender: mgerlach@rhweight-WRK1 To: Krzysztof Kozlowski cc: dinguyen@kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org Subject: Re: [PATCH v2 3/3] arm64: dts: intel: add device tree for n6000 In-Reply-To: <316d2e11-a12a-3a73-0d07-a606005df159@linaro.org> Message-ID: References: <20220503194546.1287679-1-matthew.gerlach@linux.intel.com> <20220503194546.1287679-4-matthew.gerlach@linux.intel.com> <608ba746-9116-3f36-d640-07eb8b5d793e@linaro.org> <316d2e11-a12a-3a73-0d07-a606005df159@linaro.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 May 2022, Krzysztof Kozlowski wrote: > On 04/05/2022 23:22, matthew.gerlach@linux.intel.com wrote: >> >> >> On Wed, 4 May 2022, Krzysztof Kozlowski wrote: >> >>> On 03/05/2022 21:45, matthew.gerlach@linux.intel.com wrote: >>>> From: Matthew Gerlach >>>> >>>> Add a device tree for the n6000 instantiation of Agilex >>>> Hard Processor System (HPS). >>>> >>>> Signed-off-by: Matthew Gerlach >>> >>>> + >>>> + soc { >>>> + agilex_hps_bridges: bus@80000000 { >>>> + compatible = "simple-bus"; >>>> + reg = <0x80000000 0x60000000>, >>>> + <0xf9000000 0x00100000>; >>>> + reg-names = "axi_h2f", "axi_h2f_lw"; >>>> + #address-cells = <0x2>; >>>> + #size-cells = <0x1>; >>>> + ranges = <0x00000000 0x00000000 0xf9000000 0x00001000>; >>>> + >>>> + hps_cp_eng@0 { >>> >>> No underscores in node names. dtc W=1 should complain about it. >> >> I will remove the underscores in the name. I didn't see a complaint when >> I compiled it with "make W=1" in the kernel tree. >> >>> The node name should be generic, matching class of a device. What is >>> this exactly? >> >> The component is a specialized IP block instantiated in the FPGA directly >> connected to the HPS. In one sense the IP block is a simple DMA >> controller, but it also has some registers for hand shaking between the >> HPS and a host processor connected to the FPGA via PCIe. Should I call >> the node, dma@0? > > Then maybe the closest is dma-controller. OK, I will call it dma-controller@0. Thanks, Matthew > > > Best regards, > Krzysztof >