From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FABFC433EF for ; Wed, 22 Jun 2022 09:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241378AbiFVJQj (ORCPT ); Wed, 22 Jun 2022 05:16:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238121AbiFVJQh (ORCPT ); Wed, 22 Jun 2022 05:16:37 -0400 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C3232738 for ; Wed, 22 Jun 2022 02:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=aEnj6RSsJ68f2qx5PM9IqL6QL82fSufUdWRfkS5+iAA=; b=P/wR+uyuuu6pIDsy9EOwy5IaYvuvHHCH05sCASsfRHcSpN9pr80dXjvj se2+CYt/6GsY2c5NeRNf898tZ3U1jwh7nmKJ6RIYZckV3VgzOqwbqsc+C F0Pz2+4SySCfBoUOm8Z+XS4PKvVHOPNofni0+mii9t/QJAdPEfi69NEKU 4=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.92,212,1650924000"; d="scan'208";a="17472762" Received: from 71-51-165-43.chvl.centurylink.net (HELO hadrien.PK5001Z) ([71.51.165.43]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 11:16:32 +0200 Date: Wed, 22 Jun 2022 05:16:21 -0400 (EDT) From: Julia Lawall X-X-Sender: julia@hadrien To: Shahab Vahedi cc: Bagas Sanjaya , Jilin Yuan , "vgupta@kernel.org" , "Julia.Lawall@inria.fr" , "rdunlap@infradead.org" , "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARC:mm:Fix syntax errors in comments In-Reply-To: <4cef89c9-3b27-11e8-2971-66b93b847ede@synopsys.com> Message-ID: References: <20220622080423.41570-1-yuanjilin@cdjrlc.com> <4cef89c9-3b27-11e8-2971-66b93b847ede@synopsys.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Jun 2022, Shahab Vahedi wrote: > On 6/22/22 10:30, Bagas Sanjaya wrote: > > > I think that this kind of cleanup patches (typofixes) are best done > > as part of **actual** work on the code in question (for example > > refactoring or fixing build errors). > > Amen! So code that is fine will have typos forever? Fixing typos in comments doesn't break git blame for the following code. And typos in comments give a bad impression about the state of the code in general. But that is a general statement. Perhaps this code does particularly need work. julia