mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-kernel@vger.kernel.org, kbuild-all@lists.01.org
Subject: [djiang:cxl-security 14/16] drivers/cxl/security.c:174:59-60: disable: first occurrence line 177, second occurrence line 181 (fwd)
Date: Sat, 23 Jul 2022 21:57:46 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2207232156500.2855@hadrien> (raw)

Double initialization of disable, with different values.  See lies 177 and
181.

julia

---------- Forwarded message ----------
Date: Sat, 23 Jul 2022 13:06:56 +0800
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Cc: lkp@intel.com, Julia Lawall <julia.lawall@lip6.fr>
Subject: [djiang:cxl-security 14/16] drivers/cxl/security.c:174:59-60: disable:
    first occurrence line 177, second occurrence line 181

CC: kbuild-all@lists.01.org
BCC: lkp@intel.com
CC: linux-kernel@vger.kernel.org
TO: Dave Jiang <dave.jiang@intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git cxl-security
head:   a9e386b59eef5db739f0706d734daa39759dab96
commit: dd8bf96f3460deaf322b580b58df9f59d33ea99f [14/16] nvdimm/cxl/pmem: Add support for master passphrase disable security command
:::::: branch date: 29 hours ago
:::::: commit date: 34 hours ago
config: ia64-randconfig-c031-20220721 (https://download.01.org/0day-ci/archive/20220723/202207231241.SmvofeIK-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>

cocci warnings: (new ones prefixed by >>)
>> drivers/cxl/security.c:174:59-60: disable: first occurrence line 177, second occurrence line 181

vim +174 drivers/cxl/security.c

6d0464a727cb70c Dave Jiang 2022-07-12  173
fcbefd0f597c3ba Dave Jiang 2022-07-06 @174  static const struct nvdimm_security_ops __cxl_security_ops = {
fcbefd0f597c3ba Dave Jiang 2022-07-06  175  	.get_flags = cxl_pmem_get_security_flags,
5dce760e11e79cb Dave Jiang 2022-07-11  176  	.change_key = cxl_pmem_security_change_key,
6a299141fd67c72 Dave Jiang 2022-07-12 @177  	.disable = cxl_pmem_security_disable,
4aac0070d1a6c80 Dave Jiang 2022-07-12  178  	.freeze = cxl_pmem_security_freeze,
abef64ac4e6fcd4 Dave Jiang 2022-07-12  179  	.unlock = cxl_pmem_security_unlock,
6d0464a727cb70c Dave Jiang 2022-07-12  180  	.erase = cxl_pmem_security_passphrase_erase,
dd8bf96f3460dea Dave Jiang 2022-07-13 @181  	.disable = cxl_pmem_security_disable_master,
fcbefd0f597c3ba Dave Jiang 2022-07-06  182  };
fcbefd0f597c3ba Dave Jiang 2022-07-06  183

:::::: The code at line 174 was first introduced by commit
:::::: fcbefd0f597c3baeb916aca4f94bcbfca3571763 cxl/pmem: Introduce nvdimm_security_ops with ->get_flags() operation

:::::: TO: Dave Jiang <dave.jiang@intel.com>
:::::: CC: Dave Jiang <dave.jiang@intel.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-07-23 19:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2207232156500.2855@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=dave.jiang@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®