From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F34C433FE for ; Tue, 11 Oct 2022 12:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbiJKMQN (ORCPT ); Tue, 11 Oct 2022 08:16:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbiJKMQJ (ORCPT ); Tue, 11 Oct 2022 08:16:09 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4192E4C027 for ; Tue, 11 Oct 2022 05:16:06 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed50:3da6:62e6:8ab0:ff90]) by baptiste.telenet-ops.be with bizsmtp id WcG32800732x5mf01cG38w; Tue, 11 Oct 2022 14:16:03 +0200 Received: from geert (helo=localhost) by ramsan.of.borg with local-esmtp (Exim 4.93) (envelope-from ) id 1oiEB0-001GtL-Oy; Tue, 11 Oct 2022 14:16:02 +0200 Date: Tue, 11 Oct 2022 14:16:02 +0200 (CEST) From: Geert Uytterhoeven X-X-Sender: geert@ramsan.of.borg To: Liam Howlett cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH v14 07/70] lib/test_maple_tree: add testing for maple tree In-Reply-To: <20220906194824.2110408-8-Liam.Howlett@oracle.com> Message-ID: References: <20220906194824.2110408-1-Liam.Howlett@oracle.com> <20220906194824.2110408-8-Liam.Howlett@oracle.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liam, On Tue, 6 Sep 2022, Liam Howlett wrote: > From: "Liam R. Howlett" > > This is a test suite that uses the radix test infrastructure. It has been > split into its own commit to allow for easier review of the maple tree > code. > > The testing includes: > - Allocation of nodes > - gfp flag allocation checks > - Expansion & contraction of tree > - preallocation checks > - tree navigation by next/prev > - tree navigation by iterators (mas_for_each, etc) > - Number of nodes for a given number of entries > - Generic tree construction tests > - Addition and removal of entries in forward and reverse numerical indexes > - gap searching both forward and reverse > - Combining gaps by overwriting entries in different ways > - splitting right-most node > - splitting left-most node > - overwriting multiple slots > - overwriting across different levels of the tree > - overwriting the middle of a tree > - causing a 3-way split up to the root by overwriting the last slot and > first slot of different nodes and spanning different levels > - RCU stress testing of the tree with threads > - Duplication of the tree by entry count > - Tests which were generated by fuzzers have been added. > - A large number of tests which come from recording crashing in a VM and > reconstructing the tree (see check_erase2_set()) > > Signed-off-by: Liam R. Howlett Thanks for your patch, which is now commit e15e06a8392321a1 ("lib/test_maple_tree: add testing for maple tree"). > --- > lib/test_maple_tree.c | 38307 ++++++++++++++++++++++++++++ Does this test really belong under lib/? All other test modules there can be compiled and run as part of the kernel itself. > tools/testing/radix-tree/Makefile | 9 +- This is for userspace testing? > 2 files changed, 38314 insertions(+), 2 deletions(-) > create mode 100644 lib/test_maple_tree.c Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds