From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F629C6FD1F for ; Sat, 25 Mar 2023 14:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230118AbjCYOEi (ORCPT ); Sat, 25 Mar 2023 10:04:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjCYOEh (ORCPT ); Sat, 25 Mar 2023 10:04:37 -0400 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AA7F113C4 for ; Sat, 25 Mar 2023 07:04:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=GCBvLJhQ3scmdinTnVG7pueTv7IZRFGDspF7uPw2vAA=; b=cWpInD9UfkZPBpiBUFI3wrug7JbuUGCsvPTnQ9gIStk2BVsjQfKn+2ry reos19IJxIJjlyLx6msWidJEMgdkk6RDsycFUSW6+ELkkwFHLDQLWippB NpvUpj3DHVDlJw2sV6wGx+M9qA/O33xZexfFs27ZHdupLJYVIDOFkQLWi k=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.98,290,1673910000"; d="scan'208";a="99065710" Received: from 231.85.89.92.rev.sfr.net (HELO hadrien) ([92.89.85.231]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2023 15:04:33 +0100 Date: Sat, 25 Mar 2023 15:04:32 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Greg KH cc: Khadija Kamran , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: rtl8192u: remove change history from comments In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Mar 2023, Greg KH wrote: > On Sat, Mar 25, 2023 at 05:13:17PM +0500, Khadija Kamran wrote: > > Developers use git to browse the file history so revision history is not > > required in the comments. > > Remove the change history information from the comments. I'm not sure to follow the argument. The file was integrated into the Linux kernel in 2009. So there is no record of the 2008 date in the git history of the Linux kernel. Maybe it's not interesting, but at least the explanation doesn't seem right. julia > > > > Signed-off-by: Khadija Kamran > > --- > > drivers/staging/rtl8192u/r8192U_dm.c | 36 ---------------------------- > > 1 file changed, 36 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c > > index a88686be3523..885c5966342f 100644 > > --- a/drivers/staging/rtl8192u/r8192U_dm.c > > +++ b/drivers/staging/rtl8192u/r8192U_dm.c > > @@ -8,11 +8,6 @@ > > * Abstract: > > * HW dynamic mechanism. > > * > > - * Major Change History: > > - * When Who What > > - * ---------- --------------- ------------------------------- > > - * 2008-05-14 amy create version 0 porting from windows code. > > - * > > *-- > > */ > > #include "r8192U.h" > > @@ -276,10 +271,6 @@ void init_rate_adaptive(struct net_device *dev) > > * > > * Return: NONE > > * > > - * Revised History: > > - * When Who Remark > > - * 05/26/08 amy Create version 0 porting from windows code. > > - * > > *--------------------------------------------------------------------------- > > You can remove the extra blank comment line as well. > > thanks, > > greg k-h > >