From: Julia Lawall <julia.lawall@inria.fr>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: EEVDF and NUMA balancing
Date: Wed, 4 Oct 2023 20:04:34 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2310041958380.3108@hadrien> (raw)
In-Reply-To: <20231004174801.GE19999@noisy.programming.kicks-ass.net>
> I'll go build the benchmark thing tomorrow, if I can figure out how that
> works, this NAS stuff looked 'special'. Nothing simple like ./configure;
> make -j$lots :/
Starting from git clone, I had to do:
cd NPB3.4-OMP
mkdir bin
cd config
cp make.def.template make.def
cd ..
make ua CLASS=C
You also need gfortran to be installed.
>
> > The commit e8f331bcc270 starts with
> >
> > - if (sched_feat(PLACE_LAG) && cfs_rq->nr_running > 1) {
> > + if (sched_feat(PLACE_LAG) && cfs_rq->nr_running) {
> >
> > This seemed like a big change - cfs_rq->nr_running > 1 should be rarely
> > true in ua, while cfs_rq->nr_running should always be true. Adding back
> > the > 1 and simply replacing the test by 0 both had no effect, though.
>
> Yeah, this is because I flip the order of place_entity() and
> nr_running++ around later in the patch. Previously it would increment
> before place, now it does place before increment.
Ah, ok, not likely the source of the problem then.
Thanks,
julia
next prev parent reply other threads:[~2023-10-04 18:04 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 20:25 Julia Lawall
2023-10-03 21:51 ` Peter Zijlstra
2023-10-04 12:01 ` Julia Lawall
2023-10-04 12:05 ` Peter Zijlstra
2023-10-04 16:24 ` Julia Lawall
2023-10-04 17:48 ` Peter Zijlstra
2023-10-04 18:04 ` Julia Lawall [this message]
2023-10-09 10:29 ` Peter Zijlstra
2023-10-09 14:07 ` Julia Lawall
2023-11-11 12:56 ` Julia Lawall
2023-12-18 13:58 ` Julia Lawall
2023-12-18 17:18 ` Vincent Guittot
2023-12-18 22:31 ` Julia Lawall
2023-12-19 17:38 ` Vincent Guittot
2023-12-19 17:51 ` Julia Lawall
2023-12-20 17:09 ` Vincent Guittot
2023-12-21 18:20 ` Julia Lawall
2023-12-22 14:55 ` Vincent Guittot
2023-12-22 15:00 ` Julia Lawall
2023-12-22 15:59 ` Vincent Guittot
2023-12-22 16:18 ` Julia Lawall
2023-12-22 16:29 ` Julia Lawall
2023-12-22 16:42 ` Vincent Guittot
2023-12-28 18:34 ` Julia Lawall
2023-12-29 15:18 ` Julia Lawall
2024-01-04 16:26 ` Vincent Guittot
2024-01-04 16:45 ` Julia Lawall
2024-01-05 14:51 ` Julia Lawall
2024-01-05 16:00 ` Vincent Guittot
2024-01-05 16:39 ` Julia Lawall
2024-01-05 17:27 ` Julia Lawall
2024-01-18 16:35 ` Vincent Guittot
2024-01-18 16:50 ` Julia Lawall
2024-01-18 17:10 ` Vincent Guittot
2024-01-18 17:43 ` Julia Lawall
2024-01-18 22:13 ` Julia Lawall
2024-01-19 11:26 ` Vincent Guittot
2024-01-19 11:33 ` Julia Lawall
2024-01-26 21:20 ` Julia Lawall
2024-03-10 9:39 ` Julia Lawall
2024-01-05 20:45 ` Julia Lawall
2023-12-20 16:39 ` Julia Lawall
2023-12-20 17:11 ` Vincent Guittot
2023-10-04 18:15 ` Ingo Molnar
2023-10-04 18:20 ` Julia Lawall
2023-10-04 19:48 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2310041958380.3108@hadrien \
--to=julia.lawall@inria.fr \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®