From: Julia Lawall <julia.lawall@inria.fr>
To: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev
Subject: drivers/iio/frequency/adf4377.c:498:19-48: duplicated argument to & or | (fwd)
Date: Fri, 8 Dec 2023 07:36:17 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2312080735000.3559@hadrien> (raw)
[-- Attachment #1: Type: text/plain, Size: 3175 bytes --]
Maybe line 498 should contain ADF4377_0000_SOFT_RESET_MSK, not
ADF4377_0000_SOFT_RESET_R_MSK?
julia
---------- Forwarded message ----------
Date: Fri, 8 Dec 2023 06:19:53 +0800
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: drivers/iio/frequency/adf4377.c:498:19-48: duplicated argument to & or
|
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Antoniu Miclaus <antoniu.miclaus@analog.com>
CC: Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC: "Nuno Sá" <nuno.sa@analog.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: bee0e7762ad2c6025b9f5245c040fcc36ef2bde8
commit: eda549e2e52496d0d374ce457f514a4f14172aa5 iio: frequency: adf4377: add support for ADF4377
date: 1 year ago
:::::: branch date: 3 days ago
:::::: commit date: 1 year ago
config: x86_64-randconfig-101-20231208 (https://download.01.org/0day-ci/archive/20231208/202312080606.0wEO9f5h-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20231208/202312080606.0wEO9f5h-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202312080606.0wEO9f5h-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/iio/frequency/adf4377.c:498:19-48: duplicated argument to & or |
vim +498 drivers/iio/frequency/adf4377.c
eda549e2e52496 Antoniu Miclaus 2022-11-15 484
eda549e2e52496 Antoniu Miclaus 2022-11-15 485 static int adf4377_soft_reset(struct adf4377_state *st)
eda549e2e52496 Antoniu Miclaus 2022-11-15 486 {
eda549e2e52496 Antoniu Miclaus 2022-11-15 487 unsigned int read_val;
eda549e2e52496 Antoniu Miclaus 2022-11-15 488 int ret;
eda549e2e52496 Antoniu Miclaus 2022-11-15 489
eda549e2e52496 Antoniu Miclaus 2022-11-15 490 ret = regmap_update_bits(st->regmap, 0x0, ADF4377_0000_SOFT_RESET_MSK |
eda549e2e52496 Antoniu Miclaus 2022-11-15 491 ADF4377_0000_SOFT_RESET_R_MSK,
eda549e2e52496 Antoniu Miclaus 2022-11-15 492 FIELD_PREP(ADF4377_0000_SOFT_RESET_MSK, 1) |
eda549e2e52496 Antoniu Miclaus 2022-11-15 493 FIELD_PREP(ADF4377_0000_SOFT_RESET_R_MSK, 1));
eda549e2e52496 Antoniu Miclaus 2022-11-15 494 if (ret)
eda549e2e52496 Antoniu Miclaus 2022-11-15 495 return ret;
eda549e2e52496 Antoniu Miclaus 2022-11-15 496
eda549e2e52496 Antoniu Miclaus 2022-11-15 497 return regmap_read_poll_timeout(st->regmap, 0x0, read_val,
eda549e2e52496 Antoniu Miclaus 2022-11-15 @498 !(read_val & (ADF4377_0000_SOFT_RESET_R_MSK |
eda549e2e52496 Antoniu Miclaus 2022-11-15 499 ADF4377_0000_SOFT_RESET_R_MSK)), 200, 200 * 100);
eda549e2e52496 Antoniu Miclaus 2022-11-15 500 }
eda549e2e52496 Antoniu Miclaus 2022-11-15 501
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-12-08 6:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2312080735000.3559@hadrien \
--to=julia.lawall@inria.fr \
--cc=Jonathan.Cameron@huawei.com \
--cc=antoniu.miclaus@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®