From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Bluetooth: qca: Use common error handling code in two functions
Date: Sun, 5 May 2024 12:37:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2405051236040.3397@hadrien> (raw)
In-Reply-To: <31f78b18-0caa-45c0-af84-c95d525a13dc@web.de>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
On Sun, 5 May 2024, Markus Elfring wrote:
> >> Add a jump target so that the setting of an error code can be better reused
> >> at the end of these function implementations.
> …
> > This reduces readability, and backwards jumps are rarely desirable.
>
> Would you like to support any other design approaches better for
> the reduction of questionable source code duplication?
Maybe cleanup.h can be used to get rid of the kfree_skb. I have no idea.
It would be nice to keep the patch in the message so that one could see
what is being discussed from the message itself.
julia
prev parent reply other threads:[~2024-05-05 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 8:39 [PATCH] " Markus Elfring
2024-05-05 9:06 ` Julia Lawall
2024-05-05 10:30 ` Markus Elfring
2024-05-05 10:37 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2405051236040.3397@hadrien \
--to=julia.lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®