From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D1AC433DF for ; Fri, 26 Jun 2020 08:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A84132080C for ; Fri, 26 Jun 2020 08:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725933AbgFZIgb (ORCPT ); Fri, 26 Jun 2020 04:36:31 -0400 Received: from mailbackend.panix.com ([166.84.1.89]:60394 "EHLO mailbackend.panix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgFZIga (ORCPT ); Fri, 26 Jun 2020 04:36:30 -0400 Received: from xps-7390 (cpe-23-242-39-94.socal.res.rr.com [23.242.39.94]) by mailbackend.panix.com (Postfix) with ESMTPSA id 49tVbc6GHczxrj; Fri, 26 Jun 2020 04:36:28 -0400 (EDT) Date: Fri, 26 Jun 2020 01:36:26 -0700 (PDT) From: "Kenneth R. Crudup" Reply-To: "Kenneth R. Crudup" To: Linus Torvalds cc: Christoph Hellwig , Linux Kernel Mailing List Subject: Re: Commit 25f12ae45fc1 ("maccess: rename probe_kernel_address to get_kernel_nofault") causing several OOPSes In-Reply-To: Message-ID: References: <20200619065007.GA3041@lst.de> <20200619074233.GA3723@lst.de> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Jun 2020, Linus Torvalds wrote: > For me that patch makes no difference. So ... it looks like this original issue (random crashes if this commit was made and the ROMs thing isn't patched) is a red herring. For some time now, my Thunderbolt adapter (Lenovo 2nd-Gen TB dock) sometimes ... "acts up" on reboots/powerons with my laptop (Dell XPS 13 2-in-1) if I boot with it connected- I'll get random disconnects and/or lack of external video and/or its internal devices will drop offline. I suspect these crashes were related to the PCIe scribbling(?) somewhere(?) (even though I have IOMMU turned on). I can't track it down, and I think the issue may lie somewhere either with the Thunderbolt subsystem (my TB domain UUID gets regenerated on every boot and is always changing) or a bug in this Dell's BIOS (probably the likely culprit). ... in any case, I booted a fresh branch that does contain the commit in the Subject: line, and w/o Christoph's ROMs patch and as long as I don't boot with the TB adapter attached (or from a cold boot- SOMEtimes) it seems to work. So, my apologies for wasting everyone's time. -Kenny -- Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Orange County CA