From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762833AbXEXCRB (ORCPT ); Wed, 23 May 2007 22:17:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760752AbXEXCQt (ORCPT ); Wed, 23 May 2007 22:16:49 -0400 Received: from smtp1.linux-foundation.org ([207.189.120.13]:35552 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760222AbXEXCQr (ORCPT ); Wed, 23 May 2007 22:16:47 -0400 Date: Wed, 23 May 2007 19:16:33 -0700 (PDT) From: Linus Torvalds To: Bartlomiej Zolnierkiewicz , Andrew Morton cc: linux-ide@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [git patches] IDE fixes In-Reply-To: Message-ID: References: <200705240246.19039.bzolnier@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 May 2007, Linus Torvalds wrote: > > So please, please, please, realize that the compiler is _stupid_, and > fixing warnings without understanding the code is bad. Btw, this is fundamental. If you don't need to understand the code, then the compiler could have just fixed it for you, and there was no need to warn. So compiler warnings have two cases: - the compiler is being a complete a**hole, and the warning should exist. It happens. - it can be fixed, but only by understanding what the code wants to do. In no case is it ok to just "shut up the warning". Linus